GCE Windows Agent can't determine script type based on object reference |
||
Issue descriptionObject references should have a file type hint. Example log: 2018/05/15 16:40:38 GCEMetadataScripts: Starting startup scripts (version 4.2.0@1). 2018/05/15 16:40:38 GCEMetadataScripts: Found windows-startup-script-url in metadata. 2018/05/15 16:40:38 GCEMetadataScripts: ERROR main.go:320: error getting script type from url path, path: "gs://feiling-test01/cel-test-alpha-files/o/lsha256-6m22icf91n8ts20qoesb94fr0it8a9mt3kpvj9il4sh6l7t4l6mg", parsed type: "6mg" 2018/05/15 16:40:38 GCEMetadataScripts: Finished running startup scripts.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/enterprise/cel/+/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2 commit 1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2 Author: Asanka Herath <asanka@chromium.org> Date: Thu May 17 19:07:29 2018 Store startup script along with a filename hint. The GCE Windows Agent requires that the Google Cloud Storage URL to end with something that resembles a filename in order to figure out what kind of thing it is. Fortunately, we already built the infrastructure necessary to store filename hints. We just need to invoke it when storing the script. Change-Id: I32b160ae92b928c90f6272bf6ea485af6dedb42c Bug: 843323 Reviewed-on: https://chromium-review.googlesource.com/1060303 Reviewed-by: Fei Ling <feiling@chromium.org> [modify] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/common/resolver_registry_test.go [add] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/common/testdata/tiny.bin [modify] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/common/file_reference_test.go [modify] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/common/file_reference.go [modify] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/gcp/operation.go [add] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/common/fake_object_store.go [modify] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/gcp/deploy/prep_backend.go [add] https://crrev.com/1d4da8f86bdc44884a9a1efe031cc3e7f9ab92c2/go/common/fake_context.go
,
May 17 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by asanka@chromium.org
, May 15 2018