New issue
Advanced search Search tips

Issue 843321 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Assets deployed via GCP deployment manager get wrong name

Project Member Reported by asanka@chromium.org, May 15 2018

Issue description

E.g. instances have names like "windowsmachine-1" instead of "client" or whatever the asset manifest specifies.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/enterprise/cel/+/032a93e3c42f136c132a55982538b16b3d12b853

commit 032a93e3c42f136c132a55982538b16b3d12b853
Author: Asanka Herath <asanka@chromium.org>
Date: Tue May 22 19:28:16 2018

Fix naming of deployed assets.

GCP DeploymentManager doesn't respect the name property of deployed
assets. Instead it uses the map key for resources as the name of the
resources. Work around it by using the name of the asset as the map key.

Bug:  843321 
Change-Id: I58ec92dfa3bee83b1d71d18674d9754f44ab465f
Reviewed-on: https://chromium-review.googlesource.com/1060653
Reviewed-by: Fei Ling <feiling@chromium.org>

[modify] https://crrev.com/032a93e3c42f136c132a55982538b16b3d12b853/go/gcp/deploy/deployment_manifest.go
[modify] https://crrev.com/032a93e3c42f136c132a55982538b16b3d12b853/go/gcp/deploy/deployment_manifest_test.go

Comment 2 by asanka@chromium.org, May 22 2018

Status: Fixed (was: Assigned)
Marking as fixed, but we'll need to revisit this issue again.

Ideally, there would be a separation between deployment manifest identifiers and resource names. Resource names are only required to be unique within a project and within a resource type (i.e. there can be a disk named 'foo' and an instance named 'foo'). However, manifest identifiers for resources need to be unique within a single manifest regardless of type. This looks unexpected and confusing. I'll follow up internally.

Sign in to add a comment