New issue
Advanced search Search tips

Issue 843318 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 875056



Sign in to add a comment

input.gerrit_changes.project is empty

Project Member Reported by st...@chromium.org, May 15 2018

Issue description

For chromium CQ builds.

https://screenshot.googleplex.com/jwbgOUCKupC.png

https://bigquery.cloud.google.com/results/findit-for-me:US.bquijob_480637ef_16365989c0c

It would be great if we could have this field populated as well.
 

Comment 1 by st...@chromium.org, May 15 2018

Cc: liaoyuke@chromium.org

Comment 2 by no...@chromium.org, May 16 2018

I’m actually not sure if we should have that field. It might be a mistake. Why do you need it? Doesn’t CQ table provide that info?
I liked this field and I still do because this provides symmetry between Gerrit patch and Git commit.

I don't mind setting Gerrit project in CQ when triggering builds in CQ, if you tell me how :)

Comment 4 by no...@chromium.org, May 19 2018

Setting it isn’t supported in v1 today. It’s just there are other schedulers, git-cl-try, apps. I’m thinking if we want to preserve it, then bb should retrieve it from Gerrit, but there is confused deputy problem...

Comment 5 by st...@chromium.org, May 19 2018

I think it would be great if we have one place to tell both:
1) For the patch being tested, which gerrit project, gerrit change id, and gerrit patchset id it is
2) For the code checkout, which gitiles project, ref, and revision it is

Findit's new flake detection would like to index a flaky test and its occurrences with gitiles project info and gerrit project info respectively so that it could be extended to support other projects besides Chromium.

Comment 6 by mar...@chromium.org, May 21 2018

Cc: qyears...@chromium.org
Status: Available (was: Untriaged)
CC'ing Quinten as we discussed this too in the context of Tricium. While not directly related, I think about something that is coherent everywhere is valuable, the actual detail doesn't matter too much to me.
Blockedon: 875056
this will be implemented by clients specifying "project" field when scheduling new build using new ScheduleBuild API. The field will be required in the new API.

this also needed by recipes that need to know the CL project

Sign in to add a comment