Remove GamepadDispatcher::LatestConnectionChange |
|||
Issue descriptionGamepadDispatcher caches the last gamepad that was connected or disconnected as well as its index and connection state. The cached value is no longer used and can be removed. Since we don't need the gamepad or connection state, the WebGamepadListener methods DidConnectGamepad and DidDisconnectGamepad may also be combined into DidConnectOrDisconnectGamepad.
,
May 30 2018
i will take this issue.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41fba922a9ac07d8860e177c307a1ac8b05583bb commit 41fba922a9ac07d8860e177c307a1ac8b05583bb Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Wed May 30 22:44:21 2018 [GamePad] remove unused LatestConnectionChange() function. GamepadDispatcher caches the last gamepad that was connected or disconnected as well as its index and connection state. but The cached value is no longer used. Bug: 843305 Change-Id: I20b30f88d638f94b4a41f593a6976f7ae5f3d4e8 Reviewed-on: https://chromium-review.googlesource.com/1077879 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#563040} [modify] https://crrev.com/41fba922a9ac07d8860e177c307a1ac8b05583bb/third_party/blink/renderer/modules/gamepad/gamepad_dispatcher.cc [modify] https://crrev.com/41fba922a9ac07d8860e177c307a1ac8b05583bb/third_party/blink/renderer/modules/gamepad/gamepad_dispatcher.h
,
May 30 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by reillyg@chromium.org
, May 16 2018Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)