Tracking bug for improving test coverage in subresource_filter |
|
Issue descriptionWe now have code-coverage tools + dashboard, so we should use them to guide test coverage.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f6848c4393791f57082c4d19577284acc69a984 commit 0f6848c4393791f57082c4d19577284acc69a984 Author: Charlie Harrison <csharrison@chromium.org> Date: Tue May 29 15:46:32 2018 Add navigation console logger test Bug: 843304 Change-Id: I328c1d57d072c182b296870c02d545f5a0928008 Reviewed-on: https://chromium-review.googlesource.com/1073203 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#562441} [modify] https://crrev.com/0f6848c4393791f57082c4d19577284acc69a984/components/subresource_filter/content/browser/navigation_console_logger_unittest.cc
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d22675d11a1ab81e3bd0a7f9cd8c754bcb232a49 commit d22675d11a1ab81e3bd0a7f9cd8c754bcb232a49 Author: Charlie Harrison <csharrison@chromium.org> Date: Tue May 29 17:44:19 2018 Improve subframe filtering test coverage This CL adds unit tests for dryrun filtering, as well as console logging. Bug: 843304 Change-Id: I63918590f8f2033e1289da2898c44040ffc2c223 Reviewed-on: https://chromium-review.googlesource.com/1073198 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#562494} [modify] https://crrev.com/d22675d11a1ab81e3bd0a7f9cd8c754bcb232a49/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by csharrison@chromium.org
, May 15 2018