Remove Connection Migration V1 code |
||||
Issue descriptionSince we're moving to connection migration V2, V1 code should be removed.
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0da41847550d208f4ca2100b1fc87f4e699f5fde commit 0da41847550d208f4ca2100b1fc87f4e699f5fde Author: Zhongyi Shi <zhongyi@chromium.org> Date: Mon May 21 22:32:06 2018 Remove connection migration v1 tests which already have been covered in V2. There should be no consumers for V1 as finch configuration is removed in https://chromium-review.googlesource.com/1060285. Bug: 843299 Change-Id: Iaa585cd6789850e9b502ec19ff570b30e774d4b4 Reviewed-on: https://chromium-review.googlesource.com/1066799 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560379} [modify] https://crrev.com/0da41847550d208f4ca2100b1fc87f4e699f5fde/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/243e151e14cf20cb381c829560adb10f487f1efe commit 243e151e14cf20cb381c829560adb10f487f1efe Author: Zhongyi Shi <zhongyi@chromium.org> Date: Thu Jun 14 04:58:34 2018 Remove QUCI Connection Migration V1 tests that have been covered in V2. Bug: 843299 Change-Id: I6bdeecc0ba2498400a6f064e14013b37d09cb996 Reviewed-on: https://chromium-review.googlesource.com/1100380 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#567144} [modify] https://crrev.com/243e151e14cf20cb381c829560adb10f487f1efe/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a05461f3361b67d005a635004a26ba48aa998e9 commit 1a05461f3361b67d005a635004a26ba48aa998e9 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Thu Jun 14 04:59:08 2018 Switch exisiting QUIC Connection Migration test cases to test V2. It is not useful to keep V1 tests as V1 experimental option was deprecated in https://chromium-review.googlesource.com/1060285. Bug: 843299 Change-Id: I914c41e8ce209eb6f847717912b100bbb5e1481f Reviewed-on: https://chromium-review.googlesource.com/1100305 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#567145} [modify] https://crrev.com/1a05461f3361b67d005a635004a26ba48aa998e9/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 14 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3810c5e8e033f4015c17c092ef2ad339171344c commit a3810c5e8e033f4015c17c092ef2ad339171344c Author: Zhongyi Shi <zhongyi@chromium.org> Date: Fri Jun 15 23:07:19 2018 Fix default_network_ in QuicChromiumClientSession when the old default network is disconnected. Do not try migrate back to default network if it's disconnected. Remove Connection Migration V1 tests and add equivalent test coverage in V2 to test session is migrated when a new network is connected after write error. The new V2 tests are also regression tests which verifies session doesn't attempt to migrate back if default network is disconnected. Bug: 818259, 843299 Change-Id: I54c793b8110eb134d4eeaa3ec7d6d129fdd6aeef Reviewed-on: https://chromium-review.googlesource.com/1102109 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567821} [modify] https://crrev.com/a3810c5e8e033f4015c17c092ef2ad339171344c/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/a3810c5e8e033f4015c17c092ef2ad339171344c/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e2bc749ae0c900ab4c89beafe38887fce55e62c commit 1e2bc749ae0c900ab4c89beafe38887fce55e62c Author: Zhongyi Shi <zhongyi@chromium.org> Date: Sat Jun 16 02:06:07 2018 Fix test setup in MigrateOnWriteErrorWithNetworkMadeDefaultQueuedLater to test the network disconnected notification. Bug: 818259, 843299 Change-Id: I961c780dabc7628a598b1cab03231307fb705891 Reviewed-on: https://chromium-review.googlesource.com/1102988 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#567861} [modify] https://crrev.com/1e2bc749ae0c900ab4c89beafe38887fce55e62c/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb770d9123eeaef39fd6c5f740c130f15b0c6c83 commit bb770d9123eeaef39fd6c5f740c130f15b0c6c83 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Sat Jun 16 02:07:00 2018 Add an equivalent test coverage in QUIC Connection Migration V2, and remove V1 test case. This test case tests that a session will not be migrated to a broken socket when path degrading is detected with connection migration turning on. Bug: 843299 Change-Id: Ie5227808423b1dc9feed1344d85067a939bef133 Reviewed-on: https://chromium-review.googlesource.com/1101935 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567862} [modify] https://crrev.com/bb770d9123eeaef39fd6c5f740c130f15b0c6c83/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b24001c0048e8d78c078a28b260720b7d97e9502 commit b24001c0048e8d78c078a28b260720b7d97e9502 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Mon Jun 18 20:01:52 2018 Fix QUIC connection migration to cancel migrate back to default if an earlier migration has brought the session to the default network. This change also converts obsolete V1 tests for V2, adding regression test coverage. Bug: 818259, 843299 Change-Id: I8abfdb9af15af132efab62686fb014502e641198 Reviewed-on: https://chromium-review.googlesource.com/1103222 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568117} [modify] https://crrev.com/b24001c0048e8d78c078a28b260720b7d97e9502/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/b24001c0048e8d78c078a28b260720b7d97e9502/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f316b26d7cb78e887f9d3ee0a5716ffc7dd91ea commit 9f316b26d7cb78e887f9d3ee0a5716ffc7dd91ea Author: Zhongyi Shi <zhongyi@chromium.org> Date: Mon Jun 18 22:01:16 2018 Add equivalent test coverage in QUIC Connection Migration V2 and remove v1 tests. These test verifies that a session will migrate immediately to the alternate network when the default network disconnects. Bug: 818259, 843299 Change-Id: Id8be7a79db09cf6ec5e706e8bf6442351bdd11cc Reviewed-on: https://chromium-review.googlesource.com/1103608 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568186} [modify] https://crrev.com/9f316b26d7cb78e887f9d3ee0a5716ffc7dd91ea/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1b1fa4a9a19d4ab2380641c7373ef5d095ae3b0 commit b1b1fa4a9a19d4ab2380641c7373ef5d095ae3b0 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Tue Jun 19 23:13:47 2018 Add equivalent test coverage in QUIC Connection Migration V2 and remove V1 tests. This test verifies that migration will be timed out after kWaitTimeForNewNetworkSecs and closes the connection if there's no network available. Bug: 818259, 843299 Change-Id: I58e4945d84e153f621187a1b1b46ac9dbb4e3372 Reviewed-on: https://chromium-review.googlesource.com/1107106 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568634} [modify] https://crrev.com/b1b1fa4a9a19d4ab2380641c7373ef5d095ae3b0/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22fd5f556e6383f9c99d3b0ffd77f561c4971a86 commit 22fd5f556e6383f9c99d3b0ffd77f561c4971a86 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Wed Jun 20 17:39:09 2018 Add equivalent test in QUIC Connection Migration V2 and remove v1 tests. This tests verifies that session migrates to alternate network successfully on path degrading detected with async/sync write before the mgiration. Bug: 818259, 843299 Change-Id: Ie1dd92c4d21252151533601e4ae0f4857ab8d805 Reviewed-on: https://chromium-review.googlesource.com/1107166 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568907} [modify] https://crrev.com/22fd5f556e6383f9c99d3b0ffd77f561c4971a86/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ec9b36e05010052b922a72e4cdb7c39f12e216d commit 6ec9b36e05010052b922a72e4cdb7c39f12e216d Author: Zhongyi Shi <zhongyi@chromium.org> Date: Wed Jun 20 20:32:54 2018 Add equivalent test in QUIC Connection Migration V2 and remove v1 tests. This test verifies that session attempts connection migration when path degrading is detected. If there's no alternate network, session stays on the original network (not marked as going away), and has connection to cache the path degrading signal. Session can finish serving requests on the original network. Bug: 818259, 843299 Change-Id: Iab29e9a253d08b933191dc0f6dfb6b461e3e3e3e Reviewed-on: https://chromium-review.googlesource.com/1108489 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568993} [modify] https://crrev.com/6ec9b36e05010052b922a72e4cdb7c39f12e216d/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28f6e3584fd14d7ee01ee00f75f069c31e01a893 commit 28f6e3584fd14d7ee01ee00f75f069c31e01a893 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Wed Jun 20 21:15:43 2018 Add equivalent test in QUIC Connection Migration V2 and remove v1 tests. This test verifies that QuicStreamFactory broadcasts connection migration signal to all the sessions and multiple sessions migrate to new network afterwards. Bug: 818259, 843299 Change-Id: I9ade5015b9eb992bf83d23132c5aa0bfeb3563a6 Reviewed-on: https://chromium-review.googlesource.com/1108516 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569020} [modify] https://crrev.com/28f6e3584fd14d7ee01ee00f75f069c31e01a893/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0644e393f7ee46f3139e599a5e03c996eaa6869 commit a0644e393f7ee46f3139e599a5e03c996eaa6869 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Thu Jun 21 05:19:52 2018 Add equivalent test in QUIC Connection Migration V2 and remove v1 tests. These tests verify that session sends connnectivity probes on new default network before migrate to it. Bug: 818259, 843299 Change-Id: I73e9961dec23de933818e16f917f41d224fde98a Reviewed-on: https://chromium-review.googlesource.com/1109407 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569161} [modify] https://crrev.com/a0644e393f7ee46f3139e599a5e03c996eaa6869/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ac9e1fe20c1c1ececb49823178847ba6e51b59b commit 4ac9e1fe20c1c1ececb49823178847ba6e51b59b Author: Zhongyi Shi <zhongyi@chromium.org> Date: Thu Jun 21 05:21:47 2018 Add equivalent test coverage in QUIC connection migration V2 and remove v1 tests. Two tests simulates that session encounters a ASYNC/SYNCHRONOUS write error on the old network, new network connected before old network disconnects. Session should migrate successfully on write error. Two tests simulates that session encounters a ASYNC/SYNCHRONOUS write error on the old network, new network connected after old network disconnects. Session should migrate successfully on write error. Bug: 818259, 843299 Change-Id: I43206f683743675302af31b1ee86c64c258b1c9d Reviewed-on: https://chromium-review.googlesource.com/1108931 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569163} [modify] https://crrev.com/4ac9e1fe20c1c1ececb49823178847ba6e51b59b/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 22 2018
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f1d9218cf6aac408bbe7f097428f94c799f16da commit 7f1d9218cf6aac408bbe7f097428f94c799f16da Author: Zhongyi Shi <zhongyi@chromium.org> Date: Fri Jun 22 23:24:36 2018 Add equivalent test coverage in QUIC connection migration V2 and remove v1 tests. These tests verify that connection migration on write error can eventually succeed and rewrite the packet on the new network after multiple consecutive write errors. Bug: 818259, 843299 Change-Id: If9e3672dd8fb07b65aa5fa9a892ec2a7dec7babc Reviewed-on: https://chromium-review.googlesource.com/1112630 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569832} [modify] https://crrev.com/7f1d9218cf6aac408bbe7f097428f94c799f16da/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/329f5cbd77166476a47a9ed3eda9a2e58a822534 commit 329f5cbd77166476a47a9ed3eda9a2e58a822534 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Fri Jun 22 23:51:18 2018 Fix TestMigrationOnWriteErrorWithMultipleNotifications to test correct V2 behavior. There was a typo in the test which caused the test to V1 behavior previously. Bug: 843299 Change-Id: I255226a5f2febea541017fee1a27eb53141b12fa Reviewed-on: https://chromium-review.googlesource.com/1112652 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569845} [modify] https://crrev.com/329f5cbd77166476a47a9ed3eda9a2e58a822534/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea7cfe9628dd5cdfe593425dab3b8cebb777b7f4 commit ea7cfe9628dd5cdfe593425dab3b8cebb777b7f4 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Sat Jun 23 20:58:10 2018 Remove test configurations for Connection Migration V1 in QuicStreamFactoryTest. Bug: 843299 Change-Id: I53dc2d1dec079f099cc7a68376f494d9a12b4df1 Reviewed-on: https://chromium-review.googlesource.com/1112654 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569883} [modify] https://crrev.com/ea7cfe9628dd5cdfe593425dab3b8cebb777b7f4/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a commit fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a Author: Zhongyi Shi <zhongyi@chromium.org> Date: Tue Jun 26 20:48:06 2018 Remove connection migration v1 code for OnPathDegrading Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I943bbc01880a0a8c81cdcef16b884d0fdc89f55e Reviewed-on: https://chromium-review.googlesource.com/1112670 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570522} [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/components/network_session_configurator/browser/network_session_configurator_unittest.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/http/http_network_session.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/http/http_network_session.h [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/http/http_proxy_client_socket_wrapper_unittest.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_chromium_client_session_test.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_http_stream_test.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_proxy_client_socket_unittest.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_stream_factory_fuzzer.cc [modify] https://crrev.com/fc43608f11ab0e47dfaaa7cdc36e1b473e12ab2a/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c461bdb12d0412f564e7d1884245fbe3844bdf30 commit c461bdb12d0412f564e7d1884245fbe3844bdf30 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Tue Jun 26 22:07:31 2018 Remove migrate_sessions_on_network_change_ in QuicStreamFactory as it will be never set. Finch config for "migrate_sessions_on_network_change"(used by QUIC Connection Migration V1) is removed in https://chromium-review.googlesource.com/c/chromium/src/+/1060285. This change also removes unused methods. Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc4642112a82158411078893e6780e77123e2cc2 Reviewed-on: https://chromium-review.googlesource.com/1114085 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#570547} [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/components/cronet/url_request_context_config_unittest.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/components/network_session_configurator/browser/network_session_configurator_unittest.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/http/http_network_session.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/http/http_network_session.h [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/http/http_proxy_client_socket_wrapper_unittest.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_network_transaction_unittest.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_stream_factory_fuzzer.cc [modify] https://crrev.com/c461bdb12d0412f564e7d1884245fbe3844bdf30/net/quic/chromium/quic_stream_factory_test.cc
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/757fcce33275fc8ebaa53c3fac09311d0e27c90a commit 757fcce33275fc8ebaa53c3fac09311d0e27c90a Author: Zhongyi Shi <zhongyi@chromium.org> Date: Wed Jun 27 05:41:27 2018 Remove migrate_session_on_network_change in QuicChromiumClientSession which is never set to true. Connection Migration V1 option "migrate_session_on_network_change" is deprecated. Bug: 843299 Change-Id: I59f51d5e6b2221913b6ee92edbddb0137c23163b Reviewed-on: https://chromium-review.googlesource.com/1114302 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570670} [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/quic_chromium_client_session_test.cc [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/quic_http_stream_test.cc [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/quic_proxy_client_socket_unittest.cc [modify] https://crrev.com/757fcce33275fc8ebaa53c3fac09311d0e27c90a/net/quic/chromium/quic_stream_factory.cc
,
Jun 27 2018
All connection migration v1 specific code has been removed. Equivalent test coverage(which was the main reason to keep v1 code) is added in V2. Mark this bug as fixed now.
,
Jun 27 2018
\o/
,
Jun 27 2018
Congrats! |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 16 2018