New issue
Advanced search Search tips

Issue 843261 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 843069
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 776656



Sign in to add a comment

Null-dereference READ in blink::HTMLSlotElement::DetachLayoutTree

Project Member Reported by ClusterFuzz, May 15 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5098309526749184

Fuzzer: bj_broddelwerk
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::HTMLSlotElement::DetachLayoutTree
  blink::ContainerNode::DetachLayoutTree
  blink::ShadowRoot::DetachLayoutTree
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=558606:558609

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5098309526749184

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 15 2018

Components: Blink>DOM Blink>HTML
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by tkent@chromium.org, May 16 2018

Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by ClusterFuzz, May 16 2018

ClusterFuzz has detected this issue as fixed in range 558997:559001.

Detailed report: https://clusterfuzz.com/testcase?key=5098309526749184

Fuzzer: bj_broddelwerk
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::HTMLSlotElement::DetachLayoutTree
  blink::ContainerNode::DetachLayoutTree
  blink::ShadowRoot::DetachLayoutTree
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=558606:558609
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=558997:559001

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5098309526749184

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, May 16 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5098309526749184 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6836320ba930e1d75a86359f5bc4cf789d84500f

commit 6836320ba930e1d75a86359f5bc4cf789d84500f
Author: Hayato Ito <hayato@chromium.org>
Date: Wed May 16 15:04:25 2018

Fix a crash caused by touching outdated assigned_nodes

This is a tentative fix for several crashes cluster fuzzer reported.
It looks HTMLSlotElement::DetachLayoutTree is touching dirty
assigned_nodes.

It's still hard to have a minimized test case, so I'll work on that later
to investigate further. I've added TODO comment there.

Bug:  776656 , 843069 , 843261 
Change-Id: I9093e170e3c851b89612f40e764bfdbdc1532d4f
Reviewed-on: https://chromium-review.googlesource.com/1061274
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559096}
[modify] https://crrev.com/6836320ba930e1d75a86359f5bc4cf789d84500f/third_party/blink/renderer/core/html/html_slot_element.cc

Comment 6 by hayato@chromium.org, May 17 2018

Mergedinto: 843069
Status: Duplicate (was: Verified)

Comment 7 by hayato@chromium.org, May 25 2018

Blocking: 776656

Sign in to add a comment