code search no longer includes transitive closure of virtual method overrides |
|||
Issue descriptionWhen looking at a virtual method on a class, the 'references' section used to show all overrides of the method in all derived subclasses. Now, it appears that only the first descendant override is shown. For example: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_object.h?type=cs&q=LayoutObject::NodeAtPoint&l=1184 That shows four overrides in four subclasses of LayoutObject. If you click through to LayoutBox::NodeAtPoint, it shows a bunch more overrides: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_box.h?type=cs&l=684 LayoutBox inherits from LayoutBoxModelObject, which inherits from LayoutObject. So code search is smart enough to find the override in a non-direct-descendant class (LayoutBoxModelObject does not override the method). But that's where it stops. Since LayoutBox::NodeAtPoint is not 'final', code search should continue traversing the hierarchy of classes derived from LayoutBox looking for overrides.
,
May 15 2018
,
May 29 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by szager@chromium.org
, May 15 2018