Add list of files affected to each commit in a CI builder's blamelist |
|||
Issue descriptionSee this build where a bot started failing the "external/wpt/webrtc/protocol/video-codecs.html" layout test: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20Tests/69781 Its blamelist contains 21 commits. Somewhere in there is the CL responsible for making the test fail. A very common technique I used on buildbot builds (and I'm prob not the only one) was to ctrl-f for the test's name on the build page to see if any of the commits touched a file that matches the test name (because the vast majority of Chromium's test names are derived from the files that actually run them.) Searching for "video-codecs.html" on that page doesn't yield any results. However, if the files that changed were also listed in the blamelist, the searching would have yielded the change https://chromium-review.googlesource.com/c/chromium/src/+/1043886, which did indeed touch a file called "video-codecs.html" and was indeed responsible for the test failure. This is an ability that I'm missing more and more as bots switch to luci. Can we get the list of files changed added to commits in the blamelist please? (Don't know where this bug should go, so filing under milo...)
,
May 15 2018
Turns out i didn't finish this because I checked result of my https://crrev.com/c/1033469 on buildbot build, instead of buildbucket one https://luci-milo-dev.appspot.com/p/fuchsia/builds/b8946432306825662208
,
May 15 2018
argh, i missed 1 line in my previous CL :(
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/300322260bf8e274f3d2d0264ffd0decc50c8fd1 commit 300322260bf8e274f3d2d0264ffd0decc50c8fd1 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue May 15 22:49:09 2018 [milo] minor refactoring to avoid variable aliasing. R=hinoka@chromium.org Bug: 843245 Change-Id: I18bcd2998ad9605e2449c0683e9cb255fbf7e3e2 Reviewed-on: https://chromium-review.googlesource.com/1060467 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/300322260bf8e274f3d2d0264ffd0decc50c8fd1/milo/buildsource/buildbucket/build.go
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/f17f5cfdebb590a6ce09e6292fc7e621a2704543 commit f17f5cfdebb590a6ce09e6292fc7e621a2704543 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue May 15 22:58:09 2018 [milo] actually ask gitiles for TreeDiff for blamelist. R=hinoka@chromium.org Bug: 843245 Change-Id: I71a2dfc6832fcb8bebaa4433e689134ed7449b09 Reviewed-on: https://chromium-review.googlesource.com/1060468 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/f17f5cfdebb590a6ce09e6292fc7e621a2704543/milo/git/log.go
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/b8044058d1bbda5ce0e5c42cd3a95d0cff161016 commit b8044058d1bbda5ce0e5c42cd3a95d0cff161016 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue May 15 23:44:29 2018 [milo] stop using bad caches to really show files in blamelist. TBR=hinoka@chromium.org Bug: 843245 Change-Id: I6d2e4047c4ad3441212175b517e3e959bc8ae387 Reviewed-on: https://chromium-review.googlesource.com/1060086 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/b8044058d1bbda5ce0e5c42cd3a95d0cff161016/milo/git/log.go
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/5ca4cf2123d3ec046d94e09e8cb37f451836297f commit 5ca4cf2123d3ec046d94e09e8cb37f451836297f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed May 16 00:17:02 2018 [milo] fix regression for builds w/o associated gitiles/commit buildset. Regression was introduced in https://crrev.com/c/1060467. R=hinoka@chromium.org Bug: 843393 , 843245 Change-Id: If5c51bc609562ffb6be0af792ad30c0b8d0ccbbf Reviewed-on: https://chromium-review.googlesource.com/1060580 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/5ca4cf2123d3ec046d94e09e8cb37f451836297f/milo/buildsource/buildbucket/build.go
,
May 16 2018
Deployed 3063-5ca4cf2
,
May 16 2018
wicked; thnx Andrii! |
|||
►
Sign in to add a comment |
|||
Comment 1 by hinoka@chromium.org
, May 15 2018Status: Assigned (was: Untriaged)