New issue
Advanced search Search tips

Issue 843239 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Implement a shadow for the scrollable overflow menu

Project Member Reported by acondor@chromium.org, May 15 2018

Issue description

This shadow is an indicator that there is content in the menu beyond to what is visible. It requires a new renderer capable of rendering a linear gradient.
 
Blocking: 839488
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ec0f8a507bda026a4f35d2fcb195c9087a5f396

commit 1ec0f8a507bda026a4f35d2fcb195c9087a5f396
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed May 16 16:39:37 2018

Renaming GradientQuadRenderer to RadialGradientQuadRenderer

This is the first step necessary prior to introduce a LinearGradientQuadRenderer.

Bug:  843239 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I1be5e6265b99a153c3b7dba6e385f965952bac15
Reviewed-on: https://chromium-review.googlesource.com/1060120
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559135}
[modify] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/elements/full_screen_rect.cc
[modify] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/elements/rect.cc
[rename] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/renderers/radial_gradient_quad_renderer.cc
[rename] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/renderers/radial_gradient_quad_renderer.h
[modify] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/1ec0f8a507bda026a4f35d2fcb195c9087a5f396/chrome/browser/vr/ui_element_renderer.h

Blocking: -839488
Status: Assigned (was: Started)
Owner: ----
Status: Available (was: Assigned)
Status: WontFix (was: Available)
I'm not even sure what the scrollable overflow menu is. Feel free to reopen with repro steps or an image.

Sign in to add a comment