New issue
Advanced search Search tips

Issue 843237 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Events coalesced by MouseWheelEventQueue have unterminated LatencyInfos

Project Member Reported by mcnee@chromium.org, May 15 2018

Issue description

Chrome Version: 68.0.3428.0

What steps will reproduce the problem?
(1) Add a slow wheel listener to a page
document.body.addEventListener('wheel', function(e) {
  /* Do something that takes a long time */
})
(2) Open chrome://tracing/ in a separate tab
(3) Click the Record button
(4) Select Input latency
(5) Click the Record button
(6) Switch back to the tab with the slow wheel listener
(7) Scroll the page with the mouse wheel
(8) Switch back to the tracing tab
(9) Stop the recording
(10) Examine InputLatency::MouseWheel

What is the expected result?
All of the MouseWheel entries should be properly terminated

What happens instead?
There are unterminated MouseWheel entries (indicated by "Did Not Finish").
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebca3b6951172f286cfcd9a114a1af2f371f34b9

commit ebca3b6951172f286cfcd9a114a1af2f371f34b9
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed May 30 19:36:17 2018

Terminate coalesced wheel events in MouseWheelEventQueue

The MouseWheelEventQueue was coalescing wheel events without
terminating the LatencyInfos of the events that are coalesced away.

Bug:  843237 
Change-Id: Ice6d9a58dca7e9680f8476579362850582f738e0
Reviewed-on: https://chromium-review.googlesource.com/1060112
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562955}
[modify] https://crrev.com/ebca3b6951172f286cfcd9a114a1af2f371f34b9/content/browser/renderer_host/input/mouse_latency_browsertest.cc
[modify] https://crrev.com/ebca3b6951172f286cfcd9a114a1af2f371f34b9/content/browser/renderer_host/input/mouse_wheel_event_queue.cc

Comment 3 by mcnee@chromium.org, May 30 2018

Status: Fixed (was: Started)

Sign in to add a comment