New issue
Advanced search Search tips

Issue 843236 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 852393
issue 849956
issue 851472
issue 852431
issue 852532



Sign in to add a comment

☂ Fix Tests with OS12 SDK

Project Member Reported by justincohen@chromium.org, May 15 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6f10930c887251dddc342ee85eb26bdf4484764

commit b6f10930c887251dddc342ee85eb26bdf4484764
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 06 02:42:06 2018

[ios] Correct Xcode version for iOS 10 tests on iOS12 bot.

NOTRY=true

Bug:  843236 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If67f7873e39cdb7aaa88c55a32d6630b1a431335
Reviewed-on: https://chromium-review.googlesource.com/1087935
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564772}
[modify] https://crrev.com/b6f10930c887251dddc342ee85eb26bdf4484764/ios/build/bots/chromium.fyi/ios12-sdk-simulator.json
[modify] https://crrev.com/b6f10930c887251dddc342ee85eb26bdf4484764/ios/build/bots/chromium.mac/ios12-sdk-simulator.json

Blockedon: 849956
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d16e89375c1578a0c9a42a043f1c8721852d555

commit 9d16e89375c1578a0c9a42a043f1c8721852d555
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 06 15:55:23 2018

[ios] Correct host os version for iOS 12 tests.

Limit to 10.13.4 or 10.13.5.

NOTRY=true

Bug:  843236 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4319717afc3ad7d8fa64e2276c3b877d5f7b6837
Reviewed-on: https://chromium-review.googlesource.com/1089037
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564908}
[modify] https://crrev.com/9d16e89375c1578a0c9a42a043f1c8721852d555/ios/build/bots/chromium.fyi/ios12-sdk-simulator.json
[modify] https://crrev.com/9d16e89375c1578a0c9a42a043f1c8721852d555/ios/build/bots/chromium.mac/ios12-sdk-simulator.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3b61b20b21b4ccdc03359f4b52d38f865dfdc40

commit f3b61b20b21b4ccdc03359f4b52d38f865dfdc40
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 06 17:41:07 2018

[ios] Don't use GOMA on xcode_clang FYI builder.

NOTRY=true

Bug:  843236 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibfc9e785a0846c458eeb230e6545603fef5c13d2
Reviewed-on: https://chromium-review.googlesource.com/1089139
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564951}
[modify] https://crrev.com/f3b61b20b21b4ccdc03359f4b52d38f865dfdc40/ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json

Blockedon: 850333
Blockedon: -850333
Blockedon: 851472
Blockedon: 852393
Blockedon: 852431
Blockedon: 852532
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7918e30d20f596c4cb441cbc6b7bd9277f9a5e8

commit a7918e30d20f596c4cb441cbc6b7bd9277f9a5e8
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 13 22:43:49 2018

Update CertVerifyProcIOS::GetCertFailureStatusFromTrust for iOS 12.0.

iOS 12.0 introduced "Unable to build chain to root certificate." error.
This error is mapped to CERT_STATUS_INVALID and CERT_STATUS_AUTHORITY_INVALID.

Bug:  843236 , 852534
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I90e4f9f97084c2ce06d4560b7e2d695f9b5454ae
Reviewed-on: https://chromium-review.googlesource.com/1094700
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567028}
[modify] https://crrev.com/a7918e30d20f596c4cb441cbc6b7bd9277f9a5e8/net/cert/cert_verify_proc_ios.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/368bee50fdca9d336bdbd49a55087624b4f5be33

commit 368bee50fdca9d336bdbd49a55087624b4f5be33
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jul 18 02:10:28 2018

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b88f7918410615bec60c94d6849ea6a9d13274a8

commit b88f7918410615bec60c94d6849ea6a9d13274a8
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jul 18 16:22:35 2018

[ios] Fix code signing support for Xcode 10 xctests.

BUG:  843236 
Change-Id: I210265af65409181b095bbd6a00da530759fead4
Reviewed-on: https://chromium-review.googlesource.com/1140922
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576084}
[modify] https://crrev.com/b88f7918410615bec60c94d6849ea6a9d13274a8/build/config/ios/codesign.py
[modify] https://crrev.com/b88f7918410615bec60c94d6849ea6a9d13274a8/build/config/ios/rules.gni

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f8c1cf379de5774d6834f8555b140837f680654

commit 0f8c1cf379de5774d6834f8555b140837f680654
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jul 18 17:46:33 2018

[ios] Fix for Xcode 10 swarming-cron deployment.

Conditionally set IDEBundleInjection and libXCTestBundleInject.dylib based
on Xcode version.

Bug:  843236 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2a13fd1e93cbe87e80b045c1d3010f518a6ed862
Reviewed-on: https://chromium-review.googlesource.com/1141276
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576125}
[modify] https://crrev.com/0f8c1cf379de5774d6834f8555b140837f680654/ios/build/bots/scripts/test_runner.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7cfa42fdfd73c02523e51cd6caf4b12677e451e

commit f7cfa42fdfd73c02523e51cd6caf4b12677e451e
Author: Justin Cohen <justincohen@google.com>
Date: Thu Jul 19 14:25:52 2018

[ios] Roll ios/third_party/earl_grey to 451b6497352d0731e9827a338f32024e564078c6

Adds two fixes for Xcode 10 / iOS 12.

Bug:  843236 
Change-Id: If619d0899e65fd86cf98a980dd0e6b741a4f5d90
Reviewed-on: https://chromium-review.googlesource.com/1142601
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576480}
[modify] https://crrev.com/f7cfa42fdfd73c02523e51cd6caf4b12677e451e/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment