☂ Compile with OS12 SDK |
|||
Issue description☂
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2db1569218f1a28d439fcf3b031b9cce41a2f771 commit 2db1569218f1a28d439fcf3b031b9cce41a2f771 Author: Justin Cohen <justincohen@google.com> Date: Wed Jun 06 16:54:03 2018 [ios] Correct keychain usage for Xcode 10. Undefined keychain types are now defined in the iOS12 SDK, and annotated as unavailable on iOS. Remove the types that aren't used by mac or ios, and redefine the ones used by mac so it can be typedef-ed away on ios. Bug: 843234 Change-Id: If94222cde31a89185ce2f9bd6d77af8ac7c41fd7 Reviewed-on: https://chromium-review.googlesource.com/1087927 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564926} [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/base/mac/foundation_util.h [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/chrome/browser/mac/keychain_reauthorize.mm [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/components/os_crypt/keychain_password_mac.mm [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/components/wifi/wifi_service_mac.mm [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/crypto/apple_keychain.h [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/crypto/apple_keychain_ios.mm [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/crypto/apple_keychain_mac.mm [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/crypto/mock_apple_keychain.cc [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/crypto/mock_apple_keychain.h [modify] https://crrev.com/2db1569218f1a28d439fcf3b031b9cce41a2f771/crypto/mock_apple_keychain_mac.cc
,
Jun 7 2018
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/def77de524ca43746b4c3bbfccd50bdae050e1fa commit def77de524ca43746b4c3bbfccd50bdae050e1fa Author: Justin Cohen <justincohen@google.com> Date: Fri Jun 08 05:00:01 2018 [ios] Fix compile with Xcode 10 clang. Add -Wno-null-pointer-arithmetic and -Wno-unused-lambda-capture. Correct memory order argument to atomic operation error. Bug: 850333, 843234 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I34647764ebc03adfa865c32c298e24a0c1f60359 Reviewed-on: https://chromium-review.googlesource.com/1090151 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565548} [modify] https://crrev.com/def77de524ca43746b4c3bbfccd50bdae050e1fa/build/config/compiler/BUILD.gn [modify] https://crrev.com/def77de524ca43746b4c3bbfccd50bdae050e1fa/ios/chrome/browser/web/progress_indicator_egtest.mm
,
Jun 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac284762230d455cf5109d879d2460319f841a47 commit ac284762230d455cf5109d879d2460319f841a47 Author: Justin Cohen <justincohen@google.com> Date: Sun Jun 10 01:13:11 2018 [ios] Tweak iOS12 bot configs. Removes arm/64 from the xcode-clang builder. This is tested downstream instead. TBR=rohitrao NOTRY=true Bug: 843234 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iafc1920d13ae896b88f6fe51ea4d2f8a9848ef4d Reviewed-on: https://chromium-review.googlesource.com/1094309 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565901} [modify] https://crrev.com/ac284762230d455cf5109d879d2460319f841a47/ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/541ffd6ad9f5580a3f0089a7a90c1d29d555d12d commit 541ffd6ad9f5580a3f0089a7a90c1d29d555d12d Author: Justin Cohen <justincohen@google.com> Date: Wed Jun 13 23:35:47 2018 [ios] -Wno-null-pointer-arithmetic is Xcode 10 only. crrev.com/c/1090151 moved the null-pointer-arithmetic warning too far back. It's supported by Xcode 10, but not Xcode 9.3. Bug: 850333, 843234 Change-Id: I21935c592ca7b3ba75cb6fc7b7c0686564dd3ec4 Reviewed-on: https://chromium-review.googlesource.com/1099649 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567046} [modify] https://crrev.com/541ffd6ad9f5580a3f0089a7a90c1d29d555d12d/build/config/compiler/BUILD.gn |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 5 2018