New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 843211 link

Starred by 2 users
Status: Fixed
Owner:
wfh@chromium.org
Closed: May 2018
Cc:
█ cpu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DiagnosticsControllerTest.Diagnostics failing on read-only input files

Project Member Reported by wfh@chromium.org, May 15 2018 
Chrome Version: git rev fa9130fb622b
OS: Win10

What steps will reproduce the problem?
(1) Build unit_tests.exe
(2) Mark output files read-only
(3) run out\gn\unit_tests --gtest_filter=DiagnosticsControllerTest.Diagnostics

What is the expected result?

PASS

What happens instead?

[ RUN      ] DiagnosticsControllerTest.Diagnostics
../../chrome/browser/diagnostics/diagnostics_controller_unittest.cc(100): error: Expected equality of these values:
  DiagnosticsModel::TEST_OK
    Which is: 2
  info.GetResult()
    Which is: 3
Test: PathResources
Stack trace:
Backtrace:
        StackTraceGetter::CurrentStackTrace [0x03DB752A+90] (C:\src\gclient\src\third_party\googletest\custom\gtest\internal\custom\stack_trace_getter.cc:24)
        testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x03DD298A+74] (C:\src\gclient\src\third_party\googletest\src\googletest\src\gtest.cc:810)
        testing::internal::AssertHelper::operator= [0x03DD235B+75] (C:\src\gclient\src\third_party\googletest\src\googletest\src\gtest.cc:382)
        diagnostics::DiagnosticsControllerTest_Diagnostics_Test::TestBody [0x01968C5F+1199] (C:\src\gclient\src\chrome\browser\diagnostics\diagnostics_controller_unittest.cc:100)

Comment 1 by wfh@chromium.org, May 15 2018 

the failing test here is DIAGNOSTICS_PATH_RESOURCES_TEST and the error details are:

Path is not writable: out\goma32_debug\resources.pak

not sure why the diagnostics test needs the resources file to be writable to pass, and why this changed.
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e3c1f692d31ef03367a930c66fe0b7e5381f1b

commit 08e3c1f692d31ef03367a930c66fe0b7e5381f1b
Author: Will Harris <wfh@chromium.org>
Date: Wed May 23 00:04:11 2018

Fix Resources path diagnostics test to not fail for read-only files.

This removes the system level precondition and will now only run the
test if the file is actually meant to be read-only.

BUG= 843211 

Change-Id: I55abddd4f250732f815875dd626a80bda999f205
Reviewed-on: https://chromium-review.googlesource.com/1060172
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560843}
[modify] https://crrev.com/08e3c1f692d31ef03367a930c66fe0b7e5381f1b/chrome/browser/diagnostics/recon_diagnostics.cc

Comment 3 by wfh@chromium.org, May 29 2018

Status: Fixed (was: Started)
This should be Fixed now.
►

Sign in to add a comment