(And adjust the clients, which includes ntp_* at least)
Issue 844935 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b80c761d0eb1f0dff59f1eaeb06316503a298f02 commit b80c761d0eb1f0dff59f1eaeb06316503a298f02 Author: Maks Orlovich <morlovich@chromium.org> Date: Tue May 22 16:42:43 2018 ImageDataFetcher: remove apparently unused from_http_cache This is in preparation for upcoming port to SimpleURLLoader from deprecated-within-browser URLFetcher; the new API doesn't quite have a bit with exact semantics, and as no one seems to be using it, removing feels like the cleanest approach. (It's a little harder than usual to be sure if someone relies on the bool or not, however, since RequestMetadata has == operator; I couldn't find any use of that in production code, however) Bug: 843205 Change-Id: Iad4af72d9fae881fa8c1f70bbaf6524e5c5b1fa6 Reviewed-on: https://chromium-review.googlesource.com/1064394 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#560645} [modify] https://crrev.com/b80c761d0eb1f0dff59f1eaeb06316503a298f02/components/image_fetcher/core/image_data_fetcher.cc [modify] https://crrev.com/b80c761d0eb1f0dff59f1eaeb06316503a298f02/components/image_fetcher/core/image_data_fetcher_unittest.cc [modify] https://crrev.com/b80c761d0eb1f0dff59f1eaeb06316503a298f02/components/image_fetcher/core/request_metadata.cc [modify] https://crrev.com/b80c761d0eb1f0dff59f1eaeb06316503a298f02/components/image_fetcher/core/request_metadata.h [modify] https://crrev.com/b80c761d0eb1f0dff59f1eaeb06316503a298f02/components/image_fetcher/core/request_metadata_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6f27e51c78500e2530a255ea3f822fda7cbbd6d commit d6f27e51c78500e2530a255ea3f822fda7cbbd6d Author: Maks Orlovich <morlovich@chromium.org> Date: Tue Jun 05 16:14:35 2018 S13n: Port components/image_fetcher to SimpleURLLoader. URLFetcher will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Bug: 843205 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 Reviewed-on: https://chromium-review.googlesource.com/1060254 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#564526} [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/android/feed/feed_host_service_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/favicon/large_icon_service_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/search/thumbnail_source.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/signin/chrome_signin_client.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/chrome/browser/signin/chrome_signin_client.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/favicon/ios/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/favicon/ios/web_favicon_driver.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/feed/core/feed_image_manager_unittest.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/BUILD.gn [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_data_fetcher.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_data_fetcher.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_data_fetcher_unittest.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_fetcher.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_fetcher_impl.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_fetcher_impl.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/core/image_fetcher_impl_unittest.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/ios/BUILD.gn [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/ntp_snippets/remote/cached_image_fetcher_unittest.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/account_tracker_service_unittest.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/signin_client.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/test_signin_client.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/components/signin/core/browser/test_signin_client.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/application_context_impl.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/application_context_impl.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/passwords/notify_auto_signin_view_controller.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/payments/BUILD.gn [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/payments/ios_payment_instrument_finder.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/payments/ios_payment_instrument_finder.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/payments/payment_request.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/signin/ios_chrome_signin_client.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/signin/ios_chrome_signin_client.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/suggestions/suggestions_service_factory.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/test/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/test/testing_application_context.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/chrome/test/testing_application_context.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web/browser_state.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web/public/browser_state.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web_view/internal/DEPS [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web_view/internal/signin/ios_web_view_signin_client.h [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web_view/internal/signin/ios_web_view_signin_client.mm [modify] https://crrev.com/d6f27e51c78500e2530a255ea3f822fda7cbbd6d/ios/web_view/internal/signin/web_view_signin_client_factory.mm
re-opening as about to revert the code
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7c852a5282c651364eed69e2a951ce7163e8018 commit c7c852a5282c651364eed69e2a951ce7163e8018 Author: Maks Orlovich <morlovich@chromium.org> Date: Thu Jun 07 18:13:24 2018 Revert "S13n: Port components/image_fetcher to SimpleURLLoader." This reverts commit d6f27e51c78500e2530a255ea3f822fda7cbbd6d. Reason for revert: image_fetcher is used from more than UI thread, and SharedURLLoaderFactory isn't cross-thread. Note that this isn't a 100% mechanical revert since it needed a merge with some ImageDataFetcher cleanups; I also kept in some iOS glue bits that are used in a pending CL and aren't directly related to the substance of the revert. Bug: 850089 Original change's description: > S13n: Port components/image_fetcher to SimpleURLLoader. > > URLFetcher will stop working in the browser process with advent > of Network Service, and SimpleURLLoader is the replacement API > for most clients. > > Bug: 843205 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > Reviewed-on: https://chromium-review.googlesource.com/1060254 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564526} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843205 Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1090930 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#565348} [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/android/feed/feed_host_service_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/favicon/large_icon_service_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/search/thumbnail_source.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/signin/chrome_signin_client.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/chrome/browser/signin/chrome_signin_client.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/favicon/ios/DEPS [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/favicon/ios/web_favicon_driver.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/feed/core/feed_image_manager_unittest.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/DEPS [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/BUILD.gn [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_data_fetcher.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_data_fetcher.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_data_fetcher_unittest.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_fetcher.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_fetcher_impl.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_fetcher_impl.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/core/image_fetcher_impl_unittest.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/ios/BUILD.gn [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/ntp_snippets/remote/cached_image_fetcher_unittest.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/DEPS [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/account_tracker_service_unittest.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/signin_client.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/test_signin_client.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/components/signin/core/browser/test_signin_client.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/passwords/notify_auto_signin_view_controller.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/payments/BUILD.gn [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/payments/ios_payment_instrument_finder.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/payments/ios_payment_instrument_finder.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/payments/payment_request.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/signin/ios_chrome_signin_client.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/signin/ios_chrome_signin_client.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/suggestions/suggestions_service_factory.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/web_view/internal/DEPS [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/web_view/internal/signin/ios_web_view_signin_client.h [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/web_view/internal/signin/ios_web_view_signin_client.mm [modify] https://crrev.com/c7c852a5282c651364eed69e2a951ce7163e8018/ios/web_view/internal/signin/web_view_signin_client_factory.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c commit b281b03f47eda4bdbe5c6d89594b4560f7f92c1c Author: Kevin McNee <mcnee@chromium.org> Date: Thu Jun 07 18:51:48 2018 Reland "S13n: Port components/image_fetcher to SimpleURLLoader." This reverts commit c7c852a5282c651364eed69e2a951ce7163e8018. Reason for revert: This did not revert cleanly. generate_build_files is failing e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-gcc-rel/12779 Original change's description: > Revert "S13n: Port components/image_fetcher to SimpleURLLoader." > > This reverts commit d6f27e51c78500e2530a255ea3f822fda7cbbd6d. > > Reason for revert: image_fetcher is used from more than UI thread, > and SharedURLLoaderFactory isn't cross-thread. > > Note that this isn't a 100% mechanical revert since it needed a merge > with some ImageDataFetcher cleanups; I also kept in some iOS glue bits > that are used in a pending CL and aren't directly related to the substance > of the revert. > > Bug: 850089 > > Original change's description: > > S13n: Port components/image_fetcher to SimpleURLLoader. > > > > URLFetcher will stop working in the browser process with advent > > of Network Service, and SimpleURLLoader is the replacement API > > for most clients. > > > > Bug: 843205 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > > Reviewed-on: https://chromium-review.googlesource.com/1060254 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#564526} > > TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 843205 > Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1090930 > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565348} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org Change-Id: Iee4b628c585b7f3f4509f4dc0c691a012d31c874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850089, 843205 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1091305 Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565361} [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/android/feed/feed_host_service_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/favicon/large_icon_service_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/search/thumbnail_source.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/signin/chrome_signin_client.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/chrome/browser/signin/chrome_signin_client.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/favicon/ios/DEPS [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/favicon/ios/web_favicon_driver.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/feed/core/feed_image_manager_unittest.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/DEPS [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/BUILD.gn [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_data_fetcher.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_data_fetcher.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_data_fetcher_unittest.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_fetcher.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_fetcher_impl.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_fetcher_impl.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/core/image_fetcher_impl_unittest.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/ios/BUILD.gn [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/ntp_snippets/remote/cached_image_fetcher_unittest.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/DEPS [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/account_tracker_service_unittest.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/signin_client.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/test_signin_client.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/components/signin/core/browser/test_signin_client.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/passwords/notify_auto_signin_view_controller.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/payments/BUILD.gn [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/payments/ios_payment_instrument_finder.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/payments/ios_payment_instrument_finder.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/payments/payment_request.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/signin/ios_chrome_signin_client.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/signin/ios_chrome_signin_client.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/suggestions/suggestions_service_factory.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/web_view/internal/DEPS [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/web_view/internal/signin/ios_web_view_signin_client.h [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/web_view/internal/signin/ios_web_view_signin_client.mm [modify] https://crrev.com/b281b03f47eda4bdbe5c6d89594b4560f7f92c1c/ios/web_view/internal/signin/web_view_signin_client_factory.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0406e46bfc697e3bc94da7c80049129ff17a8fe commit a0406e46bfc697e3bc94da7c80049129ff17a8fe Author: Maks Orlovich <morlovich@chromium.org> Date: Fri Jun 08 01:10:44 2018 Revert "Reland "S13n: Port components/image_fetcher to SimpleURLLoader."" This reverts commit b281b03f47eda4bdbe5c6d89594b4560f7f92c1c. Reason for revert: Conflicting CL also got backed out, and the original reason for reverting the port still stands --- bug that causes DCHECKs that get in the way of people Original change's description: > Reland "S13n: Port components/image_fetcher to SimpleURLLoader." > > This reverts commit c7c852a5282c651364eed69e2a951ce7163e8018. > > Reason for revert: This did not revert cleanly. generate_build_files is failing e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-gcc-rel/12779 > > Original change's description: > > Revert "S13n: Port components/image_fetcher to SimpleURLLoader." > > > > This reverts commit d6f27e51c78500e2530a255ea3f822fda7cbbd6d. > > > > Reason for revert: image_fetcher is used from more than UI thread, > > and SharedURLLoaderFactory isn't cross-thread. > > > > Note that this isn't a 100% mechanical revert since it needed a merge > > with some ImageDataFetcher cleanups; I also kept in some iOS glue bits > > that are used in a pending CL and aren't directly related to the substance > > of the revert. > > > > Bug: 850089 > > > > Original change's description: > > > S13n: Port components/image_fetcher to SimpleURLLoader. > > > > > > URLFetcher will stop working in the browser process with advent > > > of Network Service, and SimpleURLLoader is the replacement API > > > for most clients. > > > > > > Bug: 843205 > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > > > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > > > Reviewed-on: https://chromium-review.googlesource.com/1060254 > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#564526} > > > > TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 843205 > > Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > > Reviewed-on: https://chromium-review.googlesource.com/1090930 > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#565348} > > TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org > > Change-Id: Iee4b628c585b7f3f4509f4dc0c691a012d31c874 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 850089, 843205 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1091305 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565361} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org,mcnee@chromium.org Change-Id: Iee020216891b42bcc056a0c7e2b805538eae46e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850089, 843205 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1092110 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#565497} [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/android/feed/feed_host_service_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/favicon/large_icon_service_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/search/suggestions/suggestions_service_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/search/thumbnail_source.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/signin/chrome_signin_client.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/chrome/browser/signin/chrome_signin_client.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/favicon/ios/DEPS [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/favicon/ios/web_favicon_driver.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/feed/core/feed_image_manager_unittest.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/DEPS [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/BUILD.gn [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_data_fetcher.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_data_fetcher.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_data_fetcher_unittest.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_fetcher.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_fetcher_impl.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_fetcher_impl.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/core/image_fetcher_impl_unittest.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/ios/BUILD.gn [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/ntp_snippets/remote/cached_image_fetcher_unittest.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/DEPS [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/account_tracker_service_unittest.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/signin_client.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/test_signin_client.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/components/signin/core/browser/test_signin_client.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/passwords/notify_auto_signin_view_controller.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/passwords/password_controller.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/payments/BUILD.gn [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/payments/ios_payment_instrument_finder.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/payments/ios_payment_instrument_finder.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/payments/payment_request.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/signin/ios_chrome_signin_client.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/signin/ios_chrome_signin_client.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/suggestions/suggestions_service_factory.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/web_view/internal/DEPS [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/web_view/internal/signin/ios_web_view_signin_client.h [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/web_view/internal/signin/ios_web_view_signin_client.mm [modify] https://crrev.com/a0406e46bfc697e3bc94da7c80049129ff17a8fe/ios/web_view/internal/signin/web_view_signin_client_factory.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4 commit cb02821074ba14de3d6a503ef204b694b25017a4 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jun 19 15:40:30 2018 Annotate many of the browser_tests disabled under the NetworkService. Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG= 844950 , 844951 , 844952 , 853251 , 844928 , BUG= 843205 , 844949 , 844925 , 844939 , 821021, BUG=853798, 844973 , 844927 , 844926 , 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464} [modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8d81d2c3d1bf45c8cf02ededb5d869be049b36b commit e8d81d2c3d1bf45c8cf02ededb5d869be049b36b Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Jun 20 16:33:13 2018 [NTP] Move the ThumbnailSource to always run on the UI thread. Some members were being created on UI thread and used on IO thread which is definitely not recommended. Bug: 843205 Change-Id: Id1d6f0e66e8e11347e4ba4ef1a60d0559952d28d Reviewed-on: https://chromium-review.googlesource.com/1108137 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568868} [modify] https://crrev.com/e8d81d2c3d1bf45c8cf02ededb5d869be049b36b/chrome/browser/search/thumbnail_source.cc [modify] https://crrev.com/e8d81d2c3d1bf45c8cf02ededb5d869be049b36b/chrome/browser/search/thumbnail_source.h
Forgot to link: https://chromium-review.googlesource.com/c/chromium/src/+/1098035
Comment 1 by morlovich@chromium.org
, May 15 2018