New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843189 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Suggestion text misaligned vertically

Project Member Reported by jdonnelly@chromium.org, May 15 2018

Issue description

I'm seeing this with and without the various UI flags. Compare alignment in Canary to Beta in the attached screenshots.
 
suggestion-alignment-canary.PNG
4.9 KB View Download
suggestion-alignment-beta.PNG
4.9 KB View Download
Labels: OS-Mac OS-Windows
I'm seeing this on Windows and MacViews. If it's not happening on Linux, then it's probably related to  https://crbug.com/723984 .

The fix I made there (comment 11) introduced kVerticalPadding. There may be something different about how that value is being treated after the recent refactors that's different than the pre-refactor state.
I'm not seeing it on Linux.
Ok, would you mind trying to figure out what might have changed with the use of kVerticalPadding in the recent round of changes? If there's not something obvious, I can try to debug/investigate on Windows.
Cc: nyerramilli@chromium.org rbasuvula@chromium.org dschuyler@chromium.org
 Issue 842110  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a802b101bb6371124f4499f94b8e68b309a72c31

commit a802b101bb6371124f4499f94b8e68b309a72c31
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed May 23 20:11:20 2018

[Omnibox] fix vertical alignment of icon and text in results

This Cl restores a kVerticalPadding which isn't necessary on Linux, but
appears to be needed on Mac and Windows.

Bug:  843189 
Change-Id: Ia87d7dbaf4808c3bb4e9b2b4b4a33eed0069a6e3
Reviewed-on: https://chromium-review.googlesource.com/1069678
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561225}
[modify] https://crrev.com/a802b101bb6371124f4499f94b8e68b309a72c31/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc

Status: Fixed (was: Started)
Labels: TE-Verified-68.0.3439.0 TE-Verified-M68
Verified the fix on Mac 10.13.1 and Ubuntu 14.04 using Chrome version #68.0.3439.0 as per the comment #0.
Attaching screen shot for reference.
Observed that the text in omnibar is properly aligned.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!



Text alignment in omnibar.png
129 KB View Download

Sign in to add a comment