Suggestion text misaligned vertically |
|||||
Issue descriptionI'm seeing this with and without the various UI flags. Compare alignment in Canary to Beta in the attached screenshots.
,
May 17 2018
I'm not seeing it on Linux.
,
May 18 2018
Ok, would you mind trying to figure out what might have changed with the use of kVerticalPadding in the recent round of changes? If there's not something obvious, I can try to debug/investigate on Windows.
,
May 22 2018
Hi, looks like this issue is caused by https://chromium.googlesource.com/chromium/src/+/ddfd4d82df1f9a95a969423cf7eacf752d9b7a84 Please see issue 842110 .
,
May 22 2018
Issue 842110 has been merged into this issue.
,
May 22 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a802b101bb6371124f4499f94b8e68b309a72c31 commit a802b101bb6371124f4499f94b8e68b309a72c31 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed May 23 20:11:20 2018 [Omnibox] fix vertical alignment of icon and text in results This Cl restores a kVerticalPadding which isn't necessary on Linux, but appears to be needed on Mac and Windows. Bug: 843189 Change-Id: Ia87d7dbaf4808c3bb4e9b2b4b4a33eed0069a6e3 Reviewed-on: https://chromium-review.googlesource.com/1069678 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#561225} [modify] https://crrev.com/a802b101bb6371124f4499f94b8e68b309a72c31/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
,
May 23 2018
,
May 24 2018
Verified the fix on Mac 10.13.1 and Ubuntu 14.04 using Chrome version #68.0.3439.0 as per the comment #0. Attaching screen shot for reference. Observed that the text in omnibar is properly aligned. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jdonnelly@chromium.org
, May 17 2018