We should be firing an XR event any time we recenter by holding down the Daydream button, but we're not currently. https://immersive-web.github.io/webxr/#ref-for-dom-xrsession-onresetpose
onresetpose is an event handler attribute for the resetpose event. onresetpose exists in the IDL, so we must not be firing the event. https://immersive-web.github.io/webxr/#eventdef-xrsession-resetpose
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9076d4546dbacf13a50bd708690e5a717f0bf803 commit 9076d4546dbacf13a50bd708690e5a717f0bf803 Author: Anna Offenwanger <offenwanger@chromium.org> Date: Wed May 23 01:15:54 2018 Added reset pose event from GVR input sources Added a value to allow a resetpose event to be propogated from GVR out to the javascript. Bug: 843184 Change-Id: I5433be4f26af21fa09a35b7485d8c7911a5e89c2 Reviewed-on: https://chromium-review.googlesource.com/1063027 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#560871} [modify] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/device/vr/public/mojom/vr_service.mojom [add] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/third_party/WebKit/LayoutTests/xr/events_session_resetpose.html [modify] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js [modify] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/third_party/blink/renderer/modules/xr/xr_frame_provider.cc [modify] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/third_party/blink/renderer/modules/xr/xr_session.cc [modify] https://crrev.com/9076d4546dbacf13a50bd708690e5a717f0bf803/third_party/blink/renderer/modules/xr/xr_session.h
Removing Blink>WebVR component and assigning to Blink>WebXR
Reset pose now fires, however, it only works if you are requesting animation frames. This should be corrected to be inline with the spec.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410 commit 4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410 Author: Nicolas Pena <npm@chromium.org> Date: Thu Nov 22 22:59:21 2018 Reland "Unify input delay computations" This is a reland of 5d945012c69d754ad5b659008eac95e5f0affabc Original change's description: > Unify input delay computations > > This CL unifies the timestamp computations for FID as reported to UMA and FID as > exposed in the Web Perf API. It moves the UMA reporting from the > PageWidgetDelegate to the EventTiming class. After this CL, the same types of > events are logged by both the UMA metric and the webexposed metric. In addition, > this CL removes the check that there are default actions or event handlers from > EventTiming, which means that now the webexposed API will expose events even if > they have no associated event handlers. In particular, this means that a click > will now trigger mousedown, click, and mouseup entries, in that order. This is > reflected in changes to the layout tests. > > Bug: 897656 > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc > Reviewed-on: https://chromium-review.googlesource.com/c/1334564 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610201} TBR=dtapuska@chromium.org Bug: 897656, 843184 Change-Id: I4d97f2731fe957696c0e908d5ef3493235b52d49 Reviewed-on: https://chromium-review.googlesource.com/c/1348254 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610499} [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-only-observe-firstInput.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/dom/events/event.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/dom/events/event.h [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/dom/events/event_dispatcher.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/dom/events/event_target.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/exported/web_view_test.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/loader/interactive_detector.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/loader/interactive_detector.h [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/page/page_widget_delegate.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/timing/event_timing.cc [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/timing/event_timing.h [modify] https://crrev.com/4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410/third_party/blink/renderer/core/timing/window_performance.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b789219d9fbdf8931e17be61cb024d004690080 commit 6b789219d9fbdf8931e17be61cb024d004690080 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Nov 23 09:21:26 2018 Revert "Reland "Unify input delay computations"" This reverts commit 4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410. Reason for revert: causes flakiness in browser_tests (907981). Original change's description: > Reland "Unify input delay computations" > > This is a reland of 5d945012c69d754ad5b659008eac95e5f0affabc > > Original change's description: > > Unify input delay computations > > > > This CL unifies the timestamp computations for FID as reported to UMA and FID as > > exposed in the Web Perf API. It moves the UMA reporting from the > > PageWidgetDelegate to the EventTiming class. After this CL, the same types of > > events are logged by both the UMA metric and the webexposed metric. In addition, > > this CL removes the check that there are default actions or event handlers from > > EventTiming, which means that now the webexposed API will expose events even if > > they have no associated event handlers. In particular, this means that a click > > will now trigger mousedown, click, and mouseup entries, in that order. This is > > reflected in changes to the layout tests. > > > > Bug: 897656 > > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc > > Reviewed-on: https://chromium-review.googlesource.com/c/1334564 > > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#610201} > > TBR=dtapuska@chromium.org > > Bug: 897656, 843184 > Change-Id: I4d97f2731fe957696c0e908d5ef3493235b52d49 > Reviewed-on: https://chromium-review.googlesource.com/c/1348254 > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610499} TBR=tdresser@chromium.org,dtapuska@chromium.org,npm@chromium.org Change-Id: Ib5a3717393c14d5455bb97e92187d887465bef88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897656, 843184, 907981 Reviewed-on: https://chromium-review.googlesource.com/c/1349253 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610553} [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-only-observe-firstInput.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event.h [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event_dispatcher.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event_target.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/exported/web_view_test.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/loader/interactive_detector.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/loader/interactive_detector.h [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/page/page_widget_delegate.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/timing/event_timing.cc [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/timing/event_timing.h [modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/timing/window_performance.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6e2cb9b364649724a1577b0c842074e12b82f27 commit b6e2cb9b364649724a1577b0c842074e12b82f27 Author: Nicolas Pena <npm@chromium.org> Date: Fri Nov 30 18:24:50 2018 [EventTiming] Always buffer firstInput Before, we'd buffer the firstInput entry only if it happened before onload. This CL forces firstInput to always be buffered. This means EventTiming code is called more in some tests, so the event hardware timestamp is no longer guaranteed to be nonzero, and a couple of xr tests require double RAF to avoid competing with the swap promises from Event Timing. Bug: 841224, 843184 Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8 Reviewed-on: https://chromium-review.googlesource.com/c/1355880 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612703} [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/renderer/core/timing/event_timing.cc [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/renderer/core/timing/window_performance.cc [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/renderer/core/timing/window_performance.h [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve.html [add] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/web_tests/external/wpt/event-timing/event-timing-retrieve-firstInput.html [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/web_tests/xr/events_session_resetpose.html [modify] https://crrev.com/b6e2cb9b364649724a1577b0c842074e12b82f27/third_party/blink/web_tests/xr/xrFrameOfReference_stage_updates.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0 commit ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0 Author: Sebastien Seguin-Gagnon <sebsg@chromium.org> Date: Fri Nov 30 21:26:22 2018 Revert "[EventTiming] Always buffer firstInput" This reverts commit b6e2cb9b364649724a1577b0c842074e12b82f27. Reason for revert: Causing WebKitLayout tests failure on linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76109 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76108 Original change's description: > [EventTiming] Always buffer firstInput > > Before, we'd buffer the firstInput entry only if it happened before > onload. This CL forces firstInput to always be buffered. This means > EventTiming code is called more in some tests, so the event hardware > timestamp is no longer guaranteed to be nonzero, and a couple of xr > tests require double RAF to avoid competing with the swap promises from > Event Timing. > > Bug: 841224, 843184 > > Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8 > Reviewed-on: https://chromium-review.googlesource.com/c/1355880 > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612703} TBR=tdresser@chromium.org,npm@chromium.org Change-Id: I4b2456f4b9f44798b3157bea960d84f72a50a8bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841224, 843184 Reviewed-on: https://chromium-review.googlesource.com/c/1357404 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612790} [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/renderer/core/timing/event_timing.cc [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/renderer/core/timing/window_performance.cc [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/renderer/core/timing/window_performance.h [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve.html [delete] https://crrev.com/82ec099771f979cd73e8a28794813bb915a584fb/third_party/blink/web_tests/external/wpt/event-timing/event-timing-retrieve-firstInput.html [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/web_tests/xr/events_session_resetpose.html [modify] https://crrev.com/ba4d92c9af1699712c6dfa5ca5f7bfa5606c60e0/third_party/blink/web_tests/xr/xrFrameOfReference_stage_updates.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be290fb7d750c56e0a2845e0664ab49026d8a0d5 commit be290fb7d750c56e0a2845e0664ab49026d8a0d5 Author: Nicolas Pena <npm@chromium.org> Date: Wed Dec 05 15:28:06 2018 Reland "[EventTiming] Always buffer firstInput" This is a reland of b6e2cb9b364649724a1577b0c842074e12b82f27 Flaky tests are fixed: the assumption that wait is sufficient to expect input events to be processed is false. Original change's description: > [EventTiming] Always buffer firstInput > > Before, we'd buffer the firstInput entry only if it happened before > onload. This CL forces firstInput to always be buffered. This means > EventTiming code is called more in some tests, so the event hardware > timestamp is no longer guaranteed to be nonzero, and a couple of xr > tests require double RAF to avoid competing with the swap promises from > Event Timing. > > Bug: 841224, 843184 > > Change-Id: I942b934c387798c100da4ecfff52affb66ab94e8 > Reviewed-on: https://chromium-review.googlesource.com/c/1355880 > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612703} Bug: 823744, 843184 Change-Id: I5286f3748d35c0c9d5972d301cd5abcf6e453da4 Reviewed-on: https://chromium-review.googlesource.com/c/1358910 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#613973} [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/renderer/core/timing/event_timing.cc [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/renderer/core/timing/window_performance.cc [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/renderer/core/timing/window_performance.h [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/web_tests/external/wpt/event-timing/event-timing-bufferbeforeonload.html [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve.html [add] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/web_tests/external/wpt/event-timing/event-timing-retrieve-firstInput.html [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/web_tests/xr/events_session_resetpose.html [modify] https://crrev.com/be290fb7d750c56e0a2845e0664ab49026d8a0d5/third_party/blink/web_tests/xr/xrFrameOfReference_stage_updates.html
Comment 1 by ddorwin@chromium.org
, May 15 2018Status: Assigned (was: Available)