Code Coverage - Need ability to crate custom report picking specific components/directories |
||||
Issue descriptionWhat problem are you seeing? As a member of a Chrome feature team I would like to create a view of the Code Coverage data that covers only Components/Directories/files owned by my team. Example: A report covering: chrome/browser/vr/ chrome/browser/android/vr/ chrome/android/java/src/org/chromium/chrome/browser/vr_shell/ chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/ chrome/browser/vr/test/vr_browser_tests.md device/vr/ third_party/gvr-android-keyboard third_party/gvr-android-sdk/ third_party/libovr/ third_party/openvr/ third_party/blink/renderer/modules/vr/ third_party/blink/renderer/modules/xr/
,
May 15 2018
One idea I have in mind is that: We implement a filter using JS to allow showing report for only specific folders/files and components. And to make it easier to re-use and share filters created previously or by other folks, we allow saving a crafted filter with a given name, so next time when someone tries to view the reports with the same filter, it will be as easy as typing in the filter name and click apply. WDYT?
,
May 15 2018
Issue 826361 has been merged into this issue.
,
May 15 2018
Yes, that sounds good. dougman@, in the meantime, it should be possible to generate a report for some specific directories locally, using -f option of the script: https://cs.chromium.org/chromium/src/tools/code_coverage/coverage.py?l=1459
,
May 16 2018
How about if all of your directories are associated with some components like C1, C2, C3 and then we have https://chromium-coverage.appspot.com/reports/558266/linux/component_view_index.html?components=C1,C2,C3 I think this is a better model to have. It is important to have all directories classified and then a search interface based on that.
,
May 16 2018
+1 to the solution proposed in c#5. We're pretty flexible in terms of improving / modifying the components view page, and that sounds like a useful workflow to evaluate a particular area like "VR" or let's say "Crypto".
,
May 17 2018
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39a7832e673dc6d1fd312e26e8ead389a7526377 commit 39a7832e673dc6d1fd312e26e8ead389a7526377 Author: Abhishek Arya <inferno@chromium.org> Date: Thu May 17 02:40:53 2018 Coverage: Add filter for component view. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 843183 Change-Id: I194ad5ccfa7f6145beccc1f4b4c0e083e4f5c681 Reviewed-on: https://chromium-review.googlesource.com/1063120 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559400} [modify] https://crrev.com/39a7832e673dc6d1fd312e26e8ead389a7526377/tools/code_coverage/html_templates/table.html
,
May 17 2018
Example filter https://chromium-coverage.appspot.com/reports/559411/linux/component_view_index.html?filter=VR This should cover the 3 VR components. Note that your directory third_party/libovr is missing OWNERS file, please add that and add your component in there. once that is done, it will show up in above query. Soon, we will support using latest instead of revision so that you get latest one. Look for an update from Max on this bug when that works. https://chromium-coverage.appspot.com/reports/latest/linux/component_view_index.html?filter=VR
,
May 17 2018
Yep, just deployed. https://chromium-coverage.appspot.com/reports/latest/linux/component_view_index.html?filter=VR works |
||||
►
Sign in to add a comment |
||||
Comment 1 by liaoyuke@chromium.org
, May 15 2018