New issue
Advanced search Search tips

Issue 843169 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

58.2% regression in thread_times.simple_mobile_sites at 558242:558310

Project Member Reported by nzolghadr@chromium.org, May 15 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 15 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=843169

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4b522a1a2959c9d01fd8536b1591037a432df4eec221d7a719c8dde4b5ad8ad6


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 16 2018

Cc: yiyix@chromium.org
Owner: yiyix@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14fcd028240000

Fix Regression: Black patch is seen while opening new page by yiyix@chromium.org
https://chromium.googlesource.com/chromium/src/+/6a4ede3e8b19101ba5b1735e0a2178b9541a21a3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2578711ee47f8b8a5ba8b15108dedb50a27367

commit be2578711ee47f8b8a5ba8b15108dedb50a27367
Author: yiyix <yiyix@chromium.org>
Date: Tue May 22 16:47:54 2018

Fix regression in thread_times.key_mobile_sites_smooth

My previous change https://chromium-review.googlesource.com/1029733 has
caused several regression on mobile devices. This is because the
|content_background_color| is updated with each new compositor frame in
SubmitCompositorFrame, I forget to check if the newly received
|content_background_color| is same as the existing background color of
the view.

Bug:  843166 ,  843167 ,  843168 ,  843169 ,  843170 


Change-Id: I98a3b8e3bc9f6191871f56e3c1bc7750c119ca7c
Reviewed-on: https://chromium-review.googlesource.com/1067147
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560653}
[modify] https://crrev.com/be2578711ee47f8b8a5ba8b15108dedb50a27367/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/be2578711ee47f8b8a5ba8b15108dedb50a27367/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/be2578711ee47f8b8a5ba8b15108dedb50a27367/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/be2578711ee47f8b8a5ba8b15108dedb50a27367/content/browser/renderer_host/render_widget_host_view_base.h

Sign in to add a comment