New issue
Advanced search Search tips

Issue 843163 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chromad: Chrome does not restore correctly after crash during session start

Project Member Reported by rsorokin@chromium.org, May 15 2018

Issue description

If Chrome crashes during session start, it restarts with user "a-<obj_guid>@gmail.com". The reason it cannot find passed account id key in the local state. And fallbacks to email.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/563d76ea0f56a0eeab4d4ecdc80fcd8008300f82

commit 563d76ea0f56a0eeab4d4ecdc80fcd8008300f82
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Thu May 17 09:21:44 2018

Store ephemeral users into local state

Currently ephemeral users are not stored into local state at all. It
works bad in case Chrome crashes (or restarts) inside the session. E.g.
Chrome could not find for which user session should be restored.
This change puts data for ephemeral users into local state and wipes on
logout.

BUG=chromium:843163
TEST=TBD

Change-Id: Ice425c63ca74a0d4862e5f05ff869de185da5e6e
Reviewed-on: https://chromium-review.googlesource.com/1059785
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559467}
[modify] https://crrev.com/563d76ea0f56a0eeab4d4ecdc80fcd8008300f82/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/563d76ea0f56a0eeab4d4ecdc80fcd8008300f82/components/user_manager/known_user.cc
[modify] https://crrev.com/563d76ea0f56a0eeab4d4ecdc80fcd8008300f82/components/user_manager/known_user.h
[modify] https://crrev.com/563d76ea0f56a0eeab4d4ecdc80fcd8008300f82/components/user_manager/user_manager_base.cc

Labels: -Pri-1 Pri-2
Status: Assigned (was: Started)
This is fixed for ephemeral AD users. Cloud ephemeral users use email as and ID.
Labels: -M-68

Sign in to add a comment