macviews: security chip has a ripple |
|||
Issue descriptionIt really shouldn't. The bookmark star as well. Puzzling!
,
May 31 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ece05e951124beda1b4aa2defb48475cb190bd2d commit ece05e951124beda1b4aa2defb48475cb190bd2d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu May 31 16:59:39 2018 macviews: hide click ripples on toolbar buttons These ripples aren't used on Mac, so set their opacity here to zero. Bug: 843156 Change-Id: I35d72a965c5344b9e534cf67c2708bfdd5e8f246 Reviewed-on: https://chromium-review.googlesource.com/1080261 Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#563276} [modify] https://crrev.com/ece05e951124beda1b4aa2defb48475cb190bd2d/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/ece05e951124beda1b4aa2defb48475cb190bd2d/chrome/browser/ui/views/page_action/page_action_icon_view.cc
,
May 31 2018
,
Jul 16
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix. Verified the fix on Mac 10.13.3 using latest chrome version #69.0.3493.0 as per the comment #1. Attaching screen cast for reference. Observed that ripples under MacViews did not appear on Security Chip, New Tab Button and Bookmarks Star. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by meh...@chromium.org
, May 15 2018