New issue
Advanced search Search tips

Issue 843156 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

macviews: security chip has a ripple

Project Member Reported by ellyjo...@chromium.org, May 15 2018

Issue description

It really shouldn't. The bookmark star as well. Puzzling!
 

Comment 1 by meh...@chromium.org, May 15 2018

I don't see the ripples under MacViews.

Tested with a MacBook Air 11" Mid 2012 and macOS 10.13.4.

(I see the ripples in MacViews+MDrefresh on the Security Chip, New Tab Button and Bookmarks Star.)
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ece05e951124beda1b4aa2defb48475cb190bd2d

commit ece05e951124beda1b4aa2defb48475cb190bd2d
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu May 31 16:59:39 2018

macviews: hide click ripples on toolbar buttons

These ripples aren't used on Mac, so set their opacity here to zero.

Bug:  843156 
Change-Id: I35d72a965c5344b9e534cf67c2708bfdd5e8f246
Reviewed-on: https://chromium-review.googlesource.com/1080261
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563276}
[modify] https://crrev.com/ece05e951124beda1b4aa2defb48475cb190bd2d/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/ece05e951124beda1b4aa2defb48475cb190bd2d/chrome/browser/ui/views/page_action/page_action_icon_view.cc

Status: Fixed (was: Started)
Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix.

Verified the fix on Mac 10.13.3 using latest chrome version #69.0.3493.0 as per the comment #1.
Attaching screen cast for reference.
Observed that ripples under MacViews did not appear on Security Chip, New Tab Button and Bookmarks Star.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
843156.mp4
794 KB View Download

Sign in to add a comment