New issue
Advanced search Search tips

Issue 843155 link

Starred by 1 user
Status: Fixed
Owner:
sczs@chromium.org
Closed: May 2018
Cc:
thegreenfrog@chromium.org
rohitrao@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: ----
Pri: 3
Type: Bug
Q2



Sign in to add a comment

Bookmarks: Implement new styling for BookmarkFolderEditorViewController

Project Member Reported by sczs@chromium.org, May 15 2018 
Create new cells to implement the UIRefresh UI for the folder selection screen.  We can continue to use the existing items, just simply give them a different cellClass.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe

commit a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe
Author: sczs <sczs@chromium.org>
Date: Fri May 18 17:36:27 2018

[ios] Changes BookmarkFolderEditor style to UIRefresh.

- Creates BookmarkParentFolderCell and BookmarkTextFieldCell, these 2 cells are now based on the
UIRefresh style.
- Styles BookmarkFolderEditorViewController to match the UI Refresh style.

Screenshot:
https://drive.google.com/open?id=1cWJpGmEUNnG9VsFtfrC9CYNFKDbm2M_e

Bug:  843155 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I036f0cf3cc618fbf64393250f5372d3895f3d92d
Reviewed-on: https://chromium-review.googlesource.com/1062946
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559937}
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/bookmark_navigation_controller.mm
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.h
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/bookmark_ui_constants.mm
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/cells/BUILD.gn
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.h
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.mm
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.h
[modify] https://crrev.com/a43e34044287f1f007ba3c0d0ab20bbd7f6e6fbe/ios/chrome/browser/ui/bookmarks/cells/bookmark_text_field_item.mm

Comment 2 by sczs@chromium.org, May 18 2018

Status: Fixed (was: Started)

Comment 3 by monor...@bugs.chromium.org, May 23 2018 

The NextAction date has arrived: 2018-05-23
►

Sign in to add a comment