Default audio device labels broken with out-of-process audio service |
|||||
Issue descriptionWhen running in process default device labels look like "Default - Actual model". When running out of process they appears as " - Actual model". I guess the reason is that the audio service does not have access to the internationalized strings.
,
May 16 2018
Other services have probably had the same problem before, maybe check with services-dev?
,
May 18 2018
Alternatively, use a placeholder in the audio service and just slap the localized "Default" on in the enumeration code in the browser process.
,
May 21 2018
,
May 21 2018
,
May 22 2018
Issue 845504 has been merged into this issue.
,
May 23 2018
I'll have a look at this one. I'll filter the result of GetInputDeviceDescriptions and GetOutputDeviceDescriptions in the browser and apply the localized name there.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64be5b29d6251b8f627ed3b975d623158d0286ad commit 64be5b29d6251b8f627ed3b975d623158d0286ad Author: Max Morin <maxmorin@chromium.org> Date: Thu May 24 22:01:13 2018 Fix default device name l10n in audio service. Only the "real" name, if any, is added in the audio service. The Default/Communications prefix is applied in the browser. Also fix some lint/IWYU stuff. Bug: 843145 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8a00a5d235807c8e7aeebac4a8062fa171152da6 Reviewed-on: https://chromium-review.googlesource.com/1071447 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#561650} [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/BUILD.gn [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/android/audio_android_unittest.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_device_description.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_device_description.h [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_device_name.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_device_name.h [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_manager_base.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_manager_unittest.cc [add] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_system.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_system.h [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_system_impl.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/media/audio/audio_system_impl.h [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/services/audio/public/cpp/audio_system_to_service_adapter.cc [modify] https://crrev.com/64be5b29d6251b8f627ed3b975d623158d0286ad/services/audio/public/cpp/audio_system_to_service_adapter.h
,
May 28 2018
The CL just made it in before the branch :). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by guidou@chromium.org
, May 15 2018