The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10b0efd3ec717635143eb07ef6bbb39655e189a5

commit 10b0efd3ec717635143eb07ef6bbb39655e189a5
Author: Owen Min <zmin@chromium.org>
Date: Tue May 15 16:18:50 2018

Correct extension API permission ID order for kEnterpriseReportingPrivate

Change the order to match the enum.xml.

Bug:  843141 
Change-Id: Ib8bf9be16aaf7a5d1f9369762bd966fb8c06b5a8
Reviewed-on: https://chromium-review.googlesource.com/1059579
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558733}
[modify] https://crrev.com/10b0efd3ec717635143eb07ef6bbb39655e189a5/extensions/common/permissions/api_permission.h

This patch needs to be merged into 67 as it fixes an issue breaks extension API metrics. 

This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Is the change listed at #1 verified in Canary and will it be safe to merge? Also is this M67 regression?

The metrics (Extensions.Permissions_Install3) has been verified on Canary.

The initial code that causes the issue is new in M67.

Approving merge to M67 branch 3396 based on comment #2, #5 and #6. Please merge. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae39ce8924b4645f453372b60e931f07b79e1b5

commit 2ae39ce8924b4645f453372b60e931f07b79e1b5
Author: Owen Min <zmin@chromium.org>
Date: Thu May 17 18:57:42 2018

Merge "Correct extension API permission ID order for kEnterpriseReportingPrivate" to 67.

Change the order to match the enum.xml.

TBR=zmin@chromium.org

(cherry picked from commit 10b0efd3ec717635143eb07ef6bbb39655e189a5)

Bug:  843141 
Change-Id: Ib8bf9be16aaf7a5d1f9369762bd966fb8c06b5a8
Reviewed-on: https://chromium-review.googlesource.com/1059579
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#558733}
Reviewed-on: https://chromium-review.googlesource.com/1064722
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#625}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/2ae39ce8924b4645f453372b60e931f07b79e1b5/extensions/common/permissions/api_permission.h

zmin@ Could you please help us with repro steps to verify the fix for comment #8

Thank You...

Hi,

The enum is used for metrics. To verify the fix, I just use a mock extension who has any permission after kDeleted_ExperienceSamplingPrivate, https://cs.chromium.org/chromium/src/extensions/common/permissions/api_permission.h?q=api_permission.h&sq=package:chromium&dr=CSs&l=104

Then go to the chrome://histogram to check the metrics that are using the extension permission enum. For example, Extensions.Permissions_Load3. Check the result matches the enum.xml here:
https://cs.chromium.org/codesearch/f/chromium/src/tools/metrics/histograms/enums.xml?cl=27b79487d4c9c9db49856eaf547164f959bdaf76 (search for ExtensionPermission3)

Verified the fix on Windows, Mac and Linux using Chrome version 67.0.3396.56. 

Please find the attached screenshot of historgram for reference.

Deleted: Untitled1.png 95.3 KB

	Untitled1.png 95.3 KB View Download