New issue
Advanced search Search tips

Issue 843135 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

GrTessellator timeout / infinite loop

Project Member Reported by ClusterFuzz, May 15 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5652261255249920

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  paint_op_buffer_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=555636:555647

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5652261255249920

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 15 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 15 2018

Cc: enne@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 16 2018

Labels: OS-Mac

Comment 4 by hcm@chromium.org, May 17 2018

Components: Internals>Compositing
Labels: -Pri-1 Pri-2
Cc: senorblanco@chromium.org
Components: Internals>Compositing>OOP-Raster
Status: Available (was: Untriaged)
Most likely this while loop in simplify is going on forever (https://skia.googlesource.com/skia/+/44890ef00dabf8c47bbed3bba66a73bae8ed2f0d/src/gpu/GrTessellator.cpp#1409)

Comment 6 by enne@chromium.org, Jun 5 2018

Owner: senorblanco@chromium.org
Status: Assigned (was: Available)
Summary: GrTessellator timeout / infinite loop (was: Timeout in paint_op_buffer_fuzzer)
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/89042d5f13a56d6b663657aa58f17593123a344e

commit 89042d5f13a56d6b663657aa58f17593123a344e
Author: Stephen White <senorblanco@chromium.org>
Date: Fri Jun 08 18:26:05 2018

GrTessellator: catch missing intersections.

Sometimes the intersection check will miss an intersection (because
floating point). This can leave the active edge list in an invalid
state, where an edge pair is incorrectly ordered. The fix is to test
for edge crossings after testing for intersections, and split the
edges manually. This extra check may result in a performance hit, so
we'll have to watch the perf bots carefully.

Bug:  843135 
Change-Id: If50320413026be503cdb2d33e6c97f620e4d51a9
Reviewed-on: https://skia-review.googlesource.com/133400
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>

[modify] https://crrev.com/89042d5f13a56d6b663657aa58f17593123a344e/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/89042d5f13a56d6b663657aa58f17593123a344e/src/gpu/GrTessellator.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf8e8793f8c08f27a3e3e14eda8de41fd37e5406

commit cf8e8793f8c08f27a3e3e14eda8de41fd37e5406
Author: Stephen White <senorblanco@chromium.org>
Date: Sat Jun 09 13:21:58 2018

Mark a layout test as flaky.

Temporarily mark
virtual/gpu/fast/canvas/canvas-arc-circumference-fill.html as flaky
until the skia roll goes through.

Bug:  843135 
Change-Id: I5a730a7ac729f2eccaa4222730ecd098809aeb24
Reviewed-on: https://chromium-review.googlesource.com/1094302
Reviewed-by: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565876}
[modify] https://crrev.com/cf8e8793f8c08f27a3e3e14eda8de41fd37e5406/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f

commit ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 09 17:18:41 2018

Roll src/third_party/skia 7a45dd1..5ebb90d (40 commits)

https://skia.googlesource.com/skia.git/+log/7a45dd1..5ebb90d


git log 7a45dd1..5ebb90d --date=short --no-merges --format='%ad %ae %s'
2018-06-09 senorblanco@chromium.org Revert "remove half float workaround in GrGLGpu::onReadPixels"
2018-06-09 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 mtklein@chromium.org remove unused parts of SkTypes.h
2018-06-08 egdaniel@google.com Fall back to bilerp if we are undable to do a copy for mips.
2018-06-08 egdaniel@google.com Reland "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c3907ef..f15f886 (6 commits)
2018-06-08 bsalomon@google.com Stop passing GrPrimitiveProcessor to GrMesh::sendToGpu.
2018-06-08 herb@google.com Glyph search of desperation
2018-06-08 egdaniel@google.com Revert "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 borenet@google.com [recipes] Make ct_skps use binaries from a build task
2018-06-08 brianosman@google.com Avoid degenerate matrices (that trigger asserts) in test code
2018-06-08 mtklein@chromium.org see if we can remove this hack
2018-06-08 caryclark@skia.org rebase
2018-06-08 khushalsagar@chromium.org fonts: Perform blob analysis at SkBaseDevice layer instead of canvas.
2018-06-08 mtklein@chromium.org remove unimportant bench
2018-06-08 csmartdalton@google.com Make the SkPathRef GenIDChangeListener ref counted
2018-06-08 bsalomon@google.com Remove include of GrGLProgramBuilder.h from GrGLProgram.h and GrVkPipelineState.h
2018-06-08 csmartdalton@google.com Add a front() accessor to GrAllocator
2018-06-08 herb@google.com New more efficient run builder
2018-06-08 brucewang@google.com Add SkTypeface::makeClone.
2018-06-08 bsalomon@google.com remove half float workaround in GrGLGpu::onReadPixels
2018-06-08 brianosman@google.com Fix A2B JPEG images on GPU backed xform or color-managed canvas
2018-06-08 bungeman@google.com Add text size override to Viewer.
2018-06-08 csmartdalton@google.com Implement Sk2f::floor
2018-06-08 mtklein@chromium.org remove linear blending from SkWebpCodec
2018-06-08 senorblanco@chromium.org GrTessellator: catch missing intersections.
2018-06-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 fmalita@chromium.org SkJson
2018-06-08 enne@chromium.org Fix SkImageInfo::computeByteSize underflow
2018-06-08 egdaniel@google.com Reland "Require mips to be allocated at texture creation time and disable late allocations."
2018-06-08 bsalomon@google.com Revert "Reland "Workaround constexpr bug in MSVC 2015 in GrTextureOp""
2018-06-08 caryclark@skia.org update SkColor
2018-06-08 caryclark@skia.org fix define comments
2018-06-08 mtklein@chromium.org remove final SkTypes dependencies in SkArenaAlloc
2018-06-08 benjaminwagner@google.com Remove Win2k8 GPU jobs.
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 81970bc..c3907ef (2 commits)
2018-06-08 timliang@google.com fixed vec3 size differences and mod calculation of skslc msl backend
2018-06-08 brianosman@google.com srgb config is gone. Stop testing it.
2018-06-08 borenet@google.com Update gen_tasks.go to use unforked glog
2018-06-08 robertphillips@google.com Add a factory to any GrOp-derived class that lacked one


Created with:
  gclient setdep -r src/third_party/skia@5ebb90d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:830651 , chromium:829622 , chromium:843135 ,chromium: 819616
TBR=halcanary@chromium.org

Change-Id: If58892b6b6b2061e1b52168911b4fb49a1b990e7
Reviewed-on: https://chromium-review.googlesource.com/1094454
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565887}
[modify] https://crrev.com/ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f/DEPS

Project Member

Comment 11 by ClusterFuzz, Jun 11 2018

ClusterFuzz has detected this issue as fixed in range 565885:565888.

Detailed report: https://clusterfuzz.com/testcase?key=5652261255249920

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  paint_op_buffer_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=555636:555647
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=565885:565888

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5652261255249920

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jun 11 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5652261255249920 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment