New issue
Advanced search Search tips

Issue 843124 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

gin_unittests generally fail on Android

Project Member Reported by h...@chromium.org, May 15 2018

Issue description

Comment 1 by thakis@chromium.org, May 15 2018

Cc: jochen@chromium.org jbroman@chromium.org rmcilroy@chromium.org
Components: Blink>Bindings
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8f3f9b74ea46af2cded08c530cc67c52efd48cf

commit c8f3f9b74ea46af2cded08c530cc67c52efd48cf
Author: Hans Wennborg <hans@chromium.org>
Date: Tue May 15 15:24:39 2018

testing: Move gin_unittests to non_android_chromium_gtests

It's already excluded manually from almost all Android bots in
test_suite_exceptions.pyl, and fails if we try to run it on [1].

It seems this test simply does not reliably work on Android, and
so excluding it by default makes more sense.

For some reason, this move also enables it on some chromium.clang
bots. I'm not sure whether disabling it for those bots was intentional,
but we'll find out.

 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343

Bug:  840756 ,  842698 ,  843124 
Change-Id: I4c40bbfe66943ad77e6f970f4ca3fa1a218166d3
Reviewed-on: https://chromium-review.googlesource.com/1059514
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558709}
[modify] https://crrev.com/c8f3f9b74ea46af2cded08c530cc67c52efd48cf/testing/buildbot/chromium.android.json
[modify] https://crrev.com/c8f3f9b74ea46af2cded08c530cc67c52efd48cf/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/c8f3f9b74ea46af2cded08c530cc67c52efd48cf/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/c8f3f9b74ea46af2cded08c530cc67c52efd48cf/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/c8f3f9b74ea46af2cded08c530cc67c52efd48cf/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/c8f3f9b74ea46af2cded08c530cc67c52efd48cf/testing/buildbot/test_suites.pyl

Components: -Blink>Bindings Infra>Client>Android
I'm seeing errors missing v8 natives data file in the logs, I think this is an infra issue, not copying over the right files for tests?

[FATAL:v8_initializer.cc(329)] Couldn't mmap v8 natives data file, status code is 1
Owner: jbroman@chromium.org
Status: Started (was: Available)
I've got this one.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fba6816a48fb3ca1710092a89c96f8d870f4ccc7

commit fba6816a48fb3ca1710092a89c96f8d870f4ccc7
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Jun 07 15:45:07 2018

gin: Make gin_unittests work on Android.

Bundle whichever startup snapshot is enabled (on Android, this is
presently the pure V8 one). Disable the gin_shell test, which tries
to invoke the gin_shell binary (but that doesn't really make sense
on Android, which only supports running Android apps packaged as APKs).

Works for me locally. Assuming this sticks, a followup will re-enable
gin_unittests on the bots.

Bug:  843124 
Change-Id: Ia69a39263ed01b2d2b2664f58ec4263380a3ef00
Reviewed-on: https://chromium-review.googlesource.com/1089458
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565279}
[modify] https://crrev.com/fba6816a48fb3ca1710092a89c96f8d870f4ccc7/gin/BUILD.gn

Status: Fixed (was: Started)
Trybots and waterfall bots both seem happy now.

Sign in to add a comment