New issue
Advanced search Search tips

Issue 843119 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Check failed: !IsSecureEventInputEnabled()

Project Member Reported by vasi...@chromium.org, May 15 2018

Issue description

Before https://chromium-review.googlesource.com/c/chromium/src/+/1054675 was reverted I noticed some interesting test failure
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F40656%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout

[ RUN      ] All/PasswordManagerBrowserTestWithViewsFeature.PromptForXHRWithNewPasswordsWithoutOnSubmit/1
[20436:6403:0514/203829.486297:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
[20455:775:0514/203830.388645:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973)
[20455:775:0514/203830.389333:WARNING:vt_video_decode_accelerator_mac.cc(200)] Hardware decoding with VideoToolbox is not supported
[20455:775:0514/203830.555737:ERROR:vt_video_encode_accelerator_mac.cc(516)]  VTCompressionSessionCreate failed: -12908
[20436:775:0514/203830.975116:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[20436:775:0514/203831.793204:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[20455:775:0514/203833.279460:WARNING:ca_layer_tree_coordinator.mm(55)] Blank frame: No overlays or CALayers
[20455:775:0514/203834.533866:ERROR:gles2_command_buffer_stub.cc(345)] ContextResult::kFatalFailure: Failed to map shared state buffer.
[20455:775:0514/203834.534011:ERROR:gpu_channel.cc(634)] GpuChannel::CreateCommandBuffer(): failed to initialize CommandBufferStub
[20463:775:0514/203834.534862:ERROR:command_buffer_proxy_impl.cc(138)] Failure processing GpuChannelMsg_CreateCommandBuffer.
[20463:775:0514/203834.535019:ERROR:context_provider_command_buffer.cc(235)] GpuChannelHost failed to create command buffer.
[20436:775:0514/203834.577036:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: http://127.0.0.1:55382/password/password_xhr_submit.html (0)
[20436:775:0514/203834.577732:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "username"): (More info: https://goo.gl/9p2vKq) %o", source: http://127.0.0.1:55382/password/password_xhr_submit.html (0)
[20436:775:0514/203834.686246:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -102
[20436:62467:0514/203835.132190:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[20436:775:0514/203835.145652:FATAL:secure_password_input.mm(24)] Check failed: !IsSecureEventInputEnabled().
0   browser_tests                       0x0000000119ca9f4c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000119a62b97 logging::LogMessage::~LogMessage() + 695
2   browser_tests                       0x000000011d37cc1b (anonymous namespace)::SetPasswordInputEnabled(bool) + 283
3   browser_tests                       0x000000011d37cdd7 ui::ScopedPasswordInputEnabler::ScopedPasswordInputEnabler() + 23
4   browser_tests                       0x0000000115a007a1 content::RenderWidgetHostViewMac::SetTextInputActive(bool) + 145
5   browser_tests                       0x0000000115a00662 content::RenderWidgetHostViewMac::OnUpdateTextInputStateCalled(content::TextInputManager*, content::RenderWidgetHostViewBase*, bool) + 194
6   browser_tests                       0x0000000115a2780c content::TextInputManager::NotifyObserversAboutInputStateUpdate(content::RenderWidgetHostViewBase*, bool) + 636
7   browser_tests                       0x0000000115a26de5 content::TextInputManager::UpdateTextInputState(content::RenderWidgetHostViewBase*, content::TextInputState const&) + 1253
8   browser_tests                       0x000000011599dbfc content::RenderWidgetHostImpl::OnTextInputStateChanged(content::TextInputState const&) + 444
9   browser_tests                       0x000000011599d6cd bool IPC::MessageT<ViewHostMsg_TextInputStateChanged_Meta, std::__1::tuple<content::TextInputState>, void>::Dispatch<content::RenderWidgetHostImpl, content::RenderWidgetHostImpl, void, void (content::RenderWidgetHostImpl::*)(content::TextInputState const&)>(IPC::Message const*, content::RenderWidgetHostImpl*, content::RenderWidgetHostImpl*, void*, void (content::RenderWidgetHostImpl::*)(content::TextInputState const&)) + 397
10  browser_tests                       0x00000001159982a5 content::RenderWidgetHostImpl::OnMessageReceived(IPC::Message const&) + 757
11  browser_tests                       0x000000011592911e content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) + 1390
12  browser_tests                       0x000000011d8aaa61 IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) + 385
13  browser_tests                       0x000000011d8b233c base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::Run(base::internal::BindStateBase*) + 460
14  browser_tests                       0x0000000119a1c169 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 825
15  browser_tests                       0x0000000119a9d8f0 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 288
16  browser_tests                       0x0000000119aa849f base::MessageLoop::RunTask(base::PendingTask*) + 1391
17  browser_tests                       0x0000000119aa8f91 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 497
18  browser_tests                       0x0000000119aa9654 base::MessageLoop::DoWork() + 1444
19  browser_tests                       0x0000000119ab338d base::MessagePumpCFRunLoopBase::RunWork() + 333
20  browser_tests                       0x0000000119a69b9a base::mac::CallWithEHFrame(void () block_pointer) + 10
21  browser_tests                       0x0000000119ab1956 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 374
22  CoreFoundation                      0x00007fff4d71fa21 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
23  CoreFoundation                      0x00007fff4d7d726c __CFRunLoopDoSource0 + 108
24  CoreFoundation                      0x00007fff4d702ab0 __CFRunLoopDoSources0 + 208
25  CoreFoundation                      0x00007fff4d701f2d __CFRunLoopRun + 1293
26  CoreFoundation                      0x00007fff4d701787 CFRunLoopRunSpecific + 487
27  HIToolbox                           0x00007fff4ca0ee26 RunCurrentEventLoopInMode + 286
28  HIToolbox                           0x00007fff4ca0eb96 ReceiveNextEventCommon + 613
29  HIToolbox                           0x00007fff4ca0e914 _BlockUntilNextEventMatchingListInModeWithFilter + 64
30  AppKit                              0x00007fff4acd9f5f _DPSNextEvent + 2085
31  AppKit                              0x00007fff4b46fb4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
32  browser_tests                       0x0000000119f18aa1 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 401
33  browser_tests                       0x0000000119a69b9a base::mac::CallWithEHFrame(void () block_pointer) + 10
34  browser_tests                       0x0000000119f18652 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 770
35  AppKit                              0x00007fff4acced6d -[NSApplication run] + 764
36  browser_tests                       0x0000000119ab5f23 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 1011
37  browser_tests                       0x0000000119ab0981 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 401
38  browser_tests                       0x0000000119aa7346 base::MessageLoop::Run(bool) + 422
39  browser_tests                       0x0000000119b4284d base::RunLoop::Run() + 685
40  browser_tests                       0x000000011b2afdc2 content::MessageLoopRunner::Run() + 370
41  browser_tests                       0x000000011b2374f8 content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) + 648
42  browser_tests                       0x000000011b23114b content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) + 1019
43  browser_tests                       0x000000011b230183 content::(anonymous namespace)::ExecuteScriptWithUserGestureControl(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool) + 675
44  browser_tests                       0x000000012bfbca4f PasswordManagerBrowserTestBase::FillElementWithValue(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 511
45  browser_tests                       0x000000010f129047 password_manager::PasswordManagerBrowserTestWithViewsFeature_PromptForXHRWithNewPasswordsWithoutOnSubmit_Test::RunTestOnMainThread() + 1191
46  browser_tests                       0x000000011b221a98 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 1496
47  browser_tests                       0x0000000119f2b95e ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 10398
48  browser_tests                       0x0000000119f28c6e ChromeBrowserMainParts::PreMainMessageLoopRun() + 270
49  browser_tests                       0x0000000114d32593 content::BrowserMainLoop::PreMainMessageLoopRun() + 355
50  browser_tests                       0x0000000115d1e8df content::StartupTaskRunner::RunAllTasksNow() + 415
51  browser_tests                       0x0000000114d2e23a content::BrowserMainLoop::CreateStartupTasks() + 1850
52  browser_tests                       0x0000000114d3a025 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 469
53  browser_tests                       0x0000000114d274df content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 655
54  browser_tests                       0x00000001198b3eab content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 587
55  browser_tests                       0x00000001198b6987 content::ContentMainRunnerImpl::Run() + 1543
56  browser_tests                       0x00000001201efb3f service_manager::Main(service_manager::MainParams const&) + 5503
57  browser_tests                       0x00000001198b3b81 content::ContentMain(content::ContentMainParams const&) + 353
58  browser_tests                       0x000000011b2206c9 content::BrowserTestBase::SetUp() + 6057
59  browser_tests                       0x0000000119d6f551 InProcessBrowserTest::SetUp() + 1489
60  browser_tests                       0x00000001121210c5 testing::Test::Run() + 293
61  browser_tests                       0x0000000112123486 testing::TestInfo::Run() + 934
[20463:775:0514/203925.991596:ERROR:command_buffer_proxy_impl.cc(133)] ContextResult::kTransientFailure: Failed to send GpuChannelMsg_CreateCommandBuffer.
[20463:775:0514/203925.991672:ERROR:context_provider_command_buffer.cc(235)] GpuChannelHost failed to create command buffer.
[269/323] All/PasswordManagerBrowserTestWithViewsFeature.PromptForXHRWithNewPasswordsWithoutOnSubmit/1 (TIMED OUT)

Probably worth investigating. I'm gonna reland the patch soon.
 
Cc: ellyjo...@chromium.org
Labels: Hotlist-CocoaBrowser
Status: Available (was: Untriaged)
This looks like a cocoa bug. Will probably go away with migration to macviews?
Components: UI>Browser>Passwords
Labels: -Hotlist-CocoaBrowser
Actually, this is coming from content::RenderWidgetHostViewMac::SetTextInputActive, so it isn't going away yet.
Labels: Group-Possibly_External_or_Unrelated
Labels: -Pri-3 Pri-1
I get it today on the top of the tree whenever I focus any password field.
Labels: -Pri-1 Target-70 M-70 Pri-2
Owner: tapted@chromium.org
Status: Assigned (was: Available)
mac triage: tapted@, help? :)

I can't repro this using the steps in #4. I did:

1) Navigate to data:text/html,<input type="password">
2) Tab into the password field

... and the browser did not crash.

Kicking this down to Pri-2.
Cc: tapted@chromium.org a...@chromium.org mbl...@yandex-team.ru
Components: -UI>Browser>Passwords -Internals>Views Blink>Forms>Password
Owner: ----
Status: Available (was: Assigned)
Since browser_tests handle application focus the first item may have been a test anomaly.

But if this repros at ToT with DCHECKs enabled, that's not great.

I don't really know anything about this stuff. The DCHECKs were added in r542517 when the code was moved out of render_widget_host_view_mac.mm to somewhere common. render_widget_host_view_mac.mm never used to DCHECK. Maybe those DCHECKs make sense for Views UI, but not the renderer. Assuming the renderer logic didn't change in that CL, if it's gone this long without things getting weird, it's probably fine to remove the DCHECKs. But (as always) when doing so, it's usually good to add test coverage that tickles them - it might just require an interactive_ui_test that focuses a password field in webcontent.

Sign in to add a comment