New issue
Advanced search Search tips

Issue 843108 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 1
Type: Bug
Q2

Blocking:
issue 805166


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Bookmarks: Use TableViewPresentationController to present bookmarks

Project Member Reported by rohitrao@chromium.org, May 15 2018

Issue description

When the CollectionsUIReboot flag is enabled, use the TableViewPresentationController to display bookmarks using the new bubble style.

Ensure that the app is usable with this flag enabled.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d4c83dce4de7afe60249cf8509e751e8a67a7a

commit 72d4c83dce4de7afe60249cf8509e751e8a67a7a
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue May 15 18:11:17 2018

[ios] Uses the UIRefresh presentation style for Bookmarks.

When the BookmarksUIReboot flag is enabled, uses
TableViewPresentationController to present Bookmarks in the UIRefresh
style.

BUG= 843108 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I036d6897ec99437707abc09c550da7e63ae7a028
Reviewed-on: https://chromium-review.googlesource.com/1059716
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558776}
[modify] https://crrev.com/72d4c83dce4de7afe60249cf8509e751e8a67a7a/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/72d4c83dce4de7afe60249cf8509e751e8a67a7a/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/72d4c83dce4de7afe60249cf8509e751e8a67a7a/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/72d4c83dce4de7afe60249cf8509e751e8a67a7a/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm
[add] https://crrev.com/72d4c83dce4de7afe60249cf8509e751e8a67a7a/ios/chrome/browser/ui/bookmarks/bookmark_transitioning_delegate.h
[add] https://crrev.com/72d4c83dce4de7afe60249cf8509e751e8a67a7a/ios/chrome/browser/ui/bookmarks/bookmark_transitioning_delegate.mm

Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b717fc08df13797f5b3829c0c1b6d0b9ba535b5b

commit b717fc08df13797f5b3829c0c1b6d0b9ba535b5b
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue May 22 16:27:49 2018

[ios] Use ActionSheetCoordinator for the bookmarks context menus.

Moves away from directly using UIAlertCoordinator and switches to
ActionSheetCoordinator instead. Extends ActionSheetCoordinator to
optionally support anchoring to a UIBarButtonItem.

The implementation of ActionSheetCoordinator always reads the
|popoverPresentationController| property, which has the side effect of
forcing a popover presentation, even on phone.  In order to continue
using an action sheet presentation for legacy bookmarks, this CL
introduces a new subclass of AlertCoordinator called
LegacyBookmarksActionSheetCoordinator.  This class, used only in the
legacy bookmarks implementation, forces an action sheet presentation
without specifying an anchor point, which prevents UIKit from displaying
the context menu as a popover.

BUG= 843108 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I31781bc573d66dfd3e811dfc96980e239235593c
Reviewed-on: https://chromium-review.googlesource.com/1067419
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560637}
[modify] https://crrev.com/b717fc08df13797f5b3829c0c1b6d0b9ba535b5b/ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h
[modify] https://crrev.com/b717fc08df13797f5b3829c0c1b6d0b9ba535b5b/ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm
[modify] https://crrev.com/b717fc08df13797f5b3829c0c1b6d0b9ba535b5b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

The NextAction date has arrived: 2018-05-23
Status: Fixed (was: Started)
Labels: -small medium

Sign in to add a comment