New issue
Advanced search Search tips

Issue 843102 link

Starred by 2 users
Status: Assigned
Owner:
lizeb@chromium.org
Cc:
mattcary@chromium.org
pasko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Library prefetch sometimes fails on Android <= M

Project Member Reported by lizeb@chromium.org, May 15 2018 
From the LibraryLoader.PrefetchStatus histogram:

https://uma.googleplex.com/p/chrome/timeline_v2/?sid=0bccf62431646567d4caa8aa555123f5

The spike correlates with:
https://chromium.googlesource.com/chromium/src/+/ff4e4bf57b47

There is a much smaller spike on other android versions and also on stable starting with M66.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64059965656108b4d6a08c5b708924c2a917f58b

commit 64059965656108b4d6a08c5b708924c2a917f58b
Author: Benoit Lize <lizeb@chromium.org>
Date: Wed May 16 10:03:23 2018

android: Add a detailed histogram for library prefetch failures.

Library prefetch sometimes fails on some Android x Chrome
versions. Adding a detailed histogram to get the root cause. See the
attached bug for details.

Also a bit of cleanup:
- Move the broad histogram recording to native
- Change a few function's signatures accordingly.

Bug: 843102
Change-Id: I5952141c541f51975aca908ab800d389bac1a183
Reviewed-on: https://chromium-review.googlesource.com/1059619
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559027}
[modify] https://crrev.com/64059965656108b4d6a08c5b708924c2a917f58b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
[modify] https://crrev.com/64059965656108b4d6a08c5b708924c2a917f58b/base/android/library_loader/library_loader_hooks.cc
[modify] https://crrev.com/64059965656108b4d6a08c5b708924c2a917f58b/base/android/library_loader/library_prefetcher.cc
[modify] https://crrev.com/64059965656108b4d6a08c5b708924c2a917f58b/base/android/library_loader/library_prefetcher.h
[modify] https://crrev.com/64059965656108b4d6a08c5b708924c2a917f58b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/64059965656108b4d6a08c5b708924c2a917f58b/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment