Issue metadata
Sign in to add a comment
|
VIdeo controls background is shown on audio only files
Reported by
ben.brow...@gmail.com,
May 15 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3430.0 Safari/537.36 Example URL: https://jsbin.com/ruvakihija/1/edit?html,css,output Steps to reproduce the problem: 1. Create a video element with mp3 src without the controls attribute: https://jsbin.com/ruvakihija/1/edit?html,css,output 2. See the gray background of the controls in the video element What is the expected behavior? The controls background should be hidden. What went wrong? The gray controls background is visible. Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? Yes Chrome version: 68.0.3430.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Contents of chrome://gpu: This bug only happen in Chrome Canary 68. I can't reproduce in Chrome Beta 67 and Stable 66. In WebRTC we connect a MediaStream object to a video element. Often this stream has only audio track without a video track. This will show the gray controls background in many WebRTC apps.
,
May 15 2018
,
May 16 2018
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the latest Canary 68.0.3430.0 and latest Beta 67.0.3396.40 as per the original comment. Bisect Information: =================== Good Build: 67.0.3396.3 Bad Build : 67.0.3396.7 Unable to execute the per-revision bisect script as this issue is regressed in branch builds. Hence below is the manual Changelog URL from omahaproxy: https://chromium.googlesource.com/chromium/src/+log/67.0.3396.3..67.0.3396.7?pretty=fuller&n=10000 From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/1014181 beccahughes@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding ReleaseBlock-Stable as this is a recent regression. Please feel free to remove the same if this is not applicable. Thanks
,
May 16 2018
+steimel@ for triage. I believe we have this bug on file already.
,
May 16 2018
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00c3cffbbeff11db315ac4d74bb274558a9f26d6 commit 00c3cffbbeff11db315ac4d74bb274558a9f26d6 Author: Tommy Steimel <steimel@chromium.org> Date: Wed May 16 19:11:51 2018 [Media Controls] Only act as audio element when controls are enabled This CL prevents video tags from acting as audio tags when the controls are not enabled. This fixes a bug where video tags with only audio were showing the audio controls background despite the controls being hidden. Bug: 843101 Change-Id: Ic7bb98b198a6ec7c497d233d40d673d7cfa7e44e Reviewed-on: https://chromium-review.googlesource.com/1062225 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559218} [add] https://crrev.com/00c3cffbbeff11db315ac4d74bb274558a9f26d6/third_party/WebKit/LayoutTests/media/controls/video-does-not-act-as-audio-tag-with-controls-hidden.html [modify] https://crrev.com/00c3cffbbeff11db315ac4d74bb274558a9f26d6/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/00c3cffbbeff11db315ac4d74bb274558a9f26d6/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
,
May 16 2018
,
May 16 2018
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2018
steimel@, Pls update the bug with canary result tomorrow and let us know how safe it is to merge. Thank you.
,
May 17 2018
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the reported version 68.0.3430.0 and the issue is fixed on the latest Canary 68.0.3433.0 as per the original comment. On navigating to the given link above, can observe that the controls are hidden. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
May 17 2018
The NextAction date has arrived: 2018-05-17
,
May 17 2018
Looks good on canary
,
May 17 2018
Approving merge to M67 branch 3396 based on comment #10 and #12. Pls merge. Thank you.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d597b77f24b848696b4fbc10c4813fdcee1fcfe2 commit d597b77f24b848696b4fbc10c4813fdcee1fcfe2 Author: Tommy Steimel <steimel@chromium.org> Date: Thu May 17 17:16:22 2018 [Media Controls] Only act as audio element when controls are enabled This CL prevents video tags from acting as audio tags when the controls are not enabled. This fixes a bug where video tags with only audio were showing the audio controls background despite the controls being hidden. Bug: 843101 Change-Id: Ic7bb98b198a6ec7c497d233d40d673d7cfa7e44e Reviewed-on: https://chromium-review.googlesource.com/1062225 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#559218}(cherry picked from commit 00c3cffbbeff11db315ac4d74bb274558a9f26d6) Reviewed-on: https://chromium-review.googlesource.com/1064472 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#622} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/d597b77f24b848696b4fbc10c4813fdcee1fcfe2/third_party/WebKit/LayoutTests/media/controls/video-does-not-act-as-audio-tag-with-controls-hidden.html [modify] https://crrev.com/d597b77f24b848696b4fbc10c4813fdcee1fcfe2/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/d597b77f24b848696b4fbc10c4813fdcee1fcfe2/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
,
May 17 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by viswa.karala@chromium.org
, May 15 2018