New issue
Advanced search Search tips

Issue 843100 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Pointer-overflow in CFX_RTFBreak::EndBreak_BidiLine

Project Member Reported by ClusterFuzz, May 15 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6332936530690048

Fuzzer: libFuzzer_pdf_bidi_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Pointer-overflow
Crash Address: 
Crash State:
  CFX_RTFBreak::EndBreak_BidiLine
  CFX_RTFBreak::EndBreak
  CFX_RTFBreak::AppendChar_Others
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=558305:558317

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6332936530690048

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 15 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 15 2018

Cc: dsinclair@chromium.org jam@chromium.org brucedaw...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 62400
Status: Started (was: Assigned)
 Issue 843072  has been merged into this issue.
 Issue 842988  has been merged into this issue.
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/a68ee04cfdeb39637a06764dcb924ac806dfdf95

commit a68ee04cfdeb39637a06764dcb924ac806dfdf95
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Wed May 16 13:30:15 2018

Verify bidi pos is within range before accessing

This CL verifies that the provided BidiPos is within the acceptable size
for the vector before accessing.

Bug:  chromium:843100 
Change-Id: I2955a3ca628b19ee51dd4233726b859729c125af
Reviewed-on: https://pdfium-review.googlesource.com/32593
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/a68ee04cfdeb39637a06764dcb924ac806dfdf95/core/fxcrt/cfx_char.h
[modify] https://crrev.com/a68ee04cfdeb39637a06764dcb924ac806dfdf95/core/fxcrt/fx_bidi.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149aa1754a9eed231a72f5b89e691a683e08e604

commit 149aa1754a9eed231a72f5b89e691a683e08e604
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 16 15:16:10 2018

Roll src/third_party/pdfium/ c3aa483e1..a68ee04cf (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/c3aa483e1325..a68ee04cfdeb

$ git log c3aa483e1..a68ee04cf --date=short --no-merges --format='%ad %ae %s'
2018-05-16 dsinclair Verify bidi pos is within range before accessing

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:843100 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I538af2faea53bef08fc016efdb5eb33f10759520
Reviewed-on: https://chromium-review.googlesource.com/1061577
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559105}
[modify] https://crrev.com/149aa1754a9eed231a72f5b89e691a683e08e604/DEPS

Project Member

Comment 11 by ClusterFuzz, May 17 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5841368921145344 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by ClusterFuzz, May 17 2018

ClusterFuzz has detected this issue as fixed in range 559095:559112.

Detailed report: https://clusterfuzz.com/testcase?key=6332936530690048

Fuzzer: libFuzzer_pdf_bidi_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Pointer-overflow
Crash Address: 
Crash State:
  CFX_RTFBreak::EndBreak_BidiLine
  CFX_RTFBreak::EndBreak
  CFX_RTFBreak::AppendChar_Others
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=558305:558317
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559095:559112

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6332936530690048

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment