New issue
Advanced search Search tips

Issue 843096 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Integer-overflow in CFX_RTFBreak::AppendChar_Others

Project Member Reported by ClusterFuzz, May 15 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4887812911136768

Fuzzer: libFuzzer_pdf_bidi_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  CFX_RTFBreak::AppendChar_Others
  CFX_RTFBreak::AppendChar
  pdf_bidi_fuzzer.cc
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=558305:558317

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4887812911136768

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 15 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 15 2018

Cc: dsinclair@chromium.org jam@chromium.org brucedaw...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 62400
Status: Started (was: Assigned)
https://pdfium-review.googlesource.com/c/pdfium/+/32610
Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/99a046acd2d1ce1f093937642b6a9165f8f41986

commit 99a046acd2d1ce1f093937642b6a9165f8f41986
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Wed May 16 14:09:15 2018

Use CheckedNumeric in CFX_RTFBreak::AppendChar_Others

This CL adds verification to the m_iWidth value when adding the
characters width.

Bug:  chromium:843096 
Change-Id: I7b2e7b1e786a9cba77f5aceafbb5d2bf13dc8eb9
Reviewed-on: https://pdfium-review.googlesource.com/32610
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/99a046acd2d1ce1f093937642b6a9165f8f41986/xfa/fgas/layout/cfx_rtfbreak.cpp

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2577cfaedadd381eefbc2595b850fd6af34c0cf7

commit 2577cfaedadd381eefbc2595b850fd6af34c0cf7
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 16 16:42:00 2018

Roll src/third_party/pdfium/ a68ee04cf..99a046acd (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/a68ee04cfdeb..99a046acd2d1

$ git log a68ee04cf..99a046acd --date=short --no-merges --format='%ad %ae %s'
2018-05-16 dsinclair Use CheckedNumeric in CFX_RTFBreak::AppendChar_Others

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:843096 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7b280fe513307ec0b47613766fc373b7a500e831
Reviewed-on: https://chromium-review.googlesource.com/1061590
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559138}
[modify] https://crrev.com/2577cfaedadd381eefbc2595b850fd6af34c0cf7/DEPS

Project Member

Comment 9 by ClusterFuzz, May 17 2018

ClusterFuzz has detected this issue as fixed in range 559134:559149.

Detailed report: https://clusterfuzz.com/testcase?key=4887812911136768

Fuzzer: libFuzzer_pdf_bidi_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  CFX_RTFBreak::AppendChar_Others
  CFX_RTFBreak::AppendChar
  pdf_bidi_fuzzer.cc
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=558305:558317
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=559134:559149

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4887812911136768

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, May 17 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4887812911136768 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment