New issue
Advanced search Search tips

Issue 843093 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chromad: Fix autotest cryptohome issue

Project Member Reported by ljusten@chromium.org, May 15 2018

Issue description

We should probably wait a bit for Cryptohome to come online.

05/09 21:52:50.776 INFO |enterprise_AuthPol:0078| (Re-)starting authpolicyd...
05/09 21:52:50.778 INFO |        authpolicy:0071| restarting authpolicyd
05/09 21:52:50.778 DEBUG|             utils:0214| Running 'status authpolicyd'
05/09 21:52:50.790 DEBUG|             utils:0214| Running 'start authpolicyd'
05/09 21:52:50.888 DEBUG|             utils:0214| Running 'mkdir -p /usr/local/autotest/packages'
05/09 21:52:50.901 DEBUG|             utils:0214| Running 'test -d /usr/local/autotest/packages'
05/09 21:52:50.914 DEBUG|             utils:0214| Running 'test -e /usr/local/autotest/packages/dep-dbus_protos.tar.bz2'
05/09 21:52:50.922 INFO |          packages:0190| Fetching dep-dbus_protos.tar.bz2 from http://100.115.219.132:8082/static/sand-release/R68-10662.0.0/autotest/packages to /usr/local/autotest/packages/dep-dbus_protos.tar.bz2
05/09 21:52:50.923 DEBUG|             utils:0214| Running 'curl --connect-timeout 15 --retry 5 --retry-delay 5 -s http://100.115.219.132:8082/static/sand-release/R68-10662.0.0/autotest/packages/dep-dbus_protos.tar.bz2 -o /usr/local/autotest/packages/dep-dbus_protos.tar.bz2'
05/09 21:52:50.953 DEBUG|             utils:0214| Running 'test -e /usr/local/autotest/packages/dep-dbus_protos.tar.bz2'
05/09 21:52:50.970 INFO |          packages:0207| Successfully fetched dep-dbus_protos.tar.bz2 from http://100.115.219.132:8082/static/sand-release/R68-10662.0.0/autotest/packages/dep-dbus_protos.tar.bz2
05/09 21:52:50.973 DEBUG|             utils:0214| Running 'md5sum /usr/local/autotest/packages/dep-dbus_protos.tar.bz2 '
05/09 21:52:51.007 DEBUG|             utils:0214| Running 'test -d /usr/local/autotest/deps/dbus_protos'
05/09 21:52:51.015 DEBUG|             utils:0214| Running 'rm -rf /usr/local/autotest/deps/dbus_protos'
05/09 21:52:51.029 DEBUG|             utils:0214| Running 'mkdir -p /usr/local/autotest/deps/dbus_protos'
05/09 21:52:51.039 DEBUG|             utils:0214| Running 'tar --no-same-owner -xjf /usr/local/autotest/packages/dep-dbus_protos.tar.bz2 -C /usr/local/autotest/deps/dbus_protos'
05/09 21:52:51.057 DEBUG|             utils:0214| Running 'md5sum /usr/local/autotest/packages/dep-dbus_protos.tar.bz2 '
05/09 21:52:51.068 DEBUG|             utils:0214| Running 'echo "966b80afda578bb80b39568c0de0b5bc" > /usr/local/autotest/deps/dbus_protos/.checksum '
05/09 21:52:51.080 DEBUG|        cros_disks:0071| Getting D-Bus proxy object on bus "org.chromium.Cryptohome" and path "/org/chromium/Cryptohome"
05/09 21:52:51.082 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 598, in _exec
    _cherry_pick_call(self.initialize, *args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 746, in _cherry_pick_call
    return func(*p_args, **p_dargs)
  File "/usr/local/autotest/tests/enterprise_AuthPolicyDaemon/enterprise_AuthPolicyDaemon.py", line 82, in initialize
    bus_loop, self.autodir, self.job)
  File "/usr/local/autotest/cros/cryptohome.py", line 613, in __init__
    self.CRYPTOHOME_OBJECT_PATH)
  File "/usr/local/autotest/cros/cros_disks.py", line 72, in __init__
    self.proxy_object = bus.get_object(bus_name, object_path)
  File "/usr/local/lib64/python2.7/site-packages/dbus/bus.py", line 241, in get_object
    follow_name_owner_changes=follow_name_owner_changes)
  File "/usr/local/lib64/python2.7/site-packages/dbus/proxies.py", line 248, in __init__
    self._named_service = conn.activate_name_owner(bus_name)
  File "/usr/local/lib64/python2.7/site-packages/dbus/bus.py", line 180, in activate_name_owner
    self.start_service_by_name(bus_name)
  File "/usr/local/lib64/python2.7/site-packages/dbus/bus.py", line 278, in start_service_by_name
    'su', (bus_name, flags)))
  File "/usr/local/lib64/python2.7/site-packages/dbus/connection.py", line 651, in call_blocking
    message, timeout)
DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.Cryptohome was not provided by any .service files
05/09 21:52:51.105 DEBUG|              test:0642| Running cleanup for test.
05/09 21:52:51.106 INFO |enterprise_AuthPol:0107| Stopping authpolicyd...
05/09 21:52:51.109 INFO |        authpolicy:0090| stopping authpolicyd
05/09 21:52:51.111 DEBUG|             utils:0214| Running 'stop authpolicyd'
05/09 21:52:51.129 DEBUG|             utils:0282| [stdout] authpolicyd stop/waiting
05/09 21:52:51.131 DEBUG|   logging_manager:0627| Logging subprocess finished
05/09 21:52:51.133 DEBUG|   logging_manager:0627| Logging subprocess finished
 
Cc: apronin@chromium.org kathrelk...@chromium.org emaxx@chromium.org
Andrey, Katherine, are you aware of any issues with tests failing because Cryptohome isn't up yet when the tests try to connect? We're running into this for enterprise_AuthPolicyDaemon on newer boards like Eve.

We we have a CL up that waits for Cryptohome startup, see CL:1065684, but right now only enterprise_AuthPolicyDaemon is going to have a timeout. Would it make sense to add this timeout by default for all tests using Cryptohome?

Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1c6be4573d968e381ffa8d5b6837a471184e97ac

commit 1c6be4573d968e381ffa8d5b6837a471184e97ac
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu May 31 19:26:03 2018

Add ability to wait for Cryptohome to start up

Adds a timeout parameter to the __init__ method of the Cryptohome daemon
client. If set, the call blocks until the daemon is available or the
timeout is reached.

This will be used for enterprise_AuthPolicyDaemon to ensure that
Cryptohome is up. On some boards the test currently fails with
  DBusException: org.freedesktop.DBus.Error.ServiceUnknown:
  The name org.chromium.Cryptohome was not provided by any .service files

CQ-DEPEND=CL:*632267

BUG= chromium:843093 
TEST=cros tryjob -g *632267 -g 1076230 eve-paladin-tryjob

Change-Id: Iae1d522893067d0aed51af6e0d7ec32274d3c322
Reviewed-on: https://chromium-review.googlesource.com/1076230
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/1c6be4573d968e381ffa8d5b6837a471184e97ac/client/cros/cryptohome.py
[modify] https://crrev.com/1c6be4573d968e381ffa8d5b6837a471184e97ac/client/cros/dbus_util.py
[modify] https://crrev.com/1c6be4573d968e381ffa8d5b6837a471184e97ac/client/cros/cros_disks.py

Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-private/+/74a16b16c1b75186793b52a808233923edd6f683

commit 74a16b16c1b75186793b52a808233923edd6f683
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu May 31 19:26:02 2018

Status: Fixed (was: Assigned)
Saw a green eve.
Status: Verified (was: Fixed)

Sign in to add a comment