New issue
Advanced search Search tips

Issue 843088 link

Starred by 2 users
Status: Fixed
Owner:
mrsuyi@chromium.org
Closed: Jul 2
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Pull to refresh text in RTL is flipped

Project Member Reported by noyau@chromium.org, May 15 2018 
In experimental flags flip the "Enable Pseudo-RTL" flag. Restart the app. When using pull to refresh notice that the text is flipped. See screenshot.

I haven't checked if it is also the case in "real" RTL.
unnamed.png
159 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f0592e99ad101aaca7eedbe801f477ad17d9a0

commit 46f0592e99ad101aaca7eedbe801f477ad17d9a0
Author: Yi Su <mrsuyi@chromium.org>
Date: Mon May 28 13:57:44 2018

In RTL mode, the whole overscroll view is reversed, therefore the label
"refresh" is also reversed in a mirror way.

Bug:  843088 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id2bcef31b68b1cd6cbc336534f1113cc9a1836d1
Reviewed-on: https://chromium-review.googlesource.com/1070272
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562251}
[modify] https://crrev.com/46f0592e99ad101aaca7eedbe801f477ad17d9a0/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm

Comment 2 by noyau@chromium.org, May 30 2018

Owner: mrsuyi@chromium.org

Comment 3 by noyau@chromium.org, Jul 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment