New issue
Advanced search Search tips

Issue 843084 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css/css-masking by import https://crrev.com/c/1058915

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, May 15 2018

Issue description

WPT import https://crrev.com/c/1058915 introduced new failures in external/wpt/css/css-masking:

List of new failures:
external/wpt/css/css-masking/parsing/clip-path-invalid.html new failing tests: https://crrev.com/c/1058915/4/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/parsing/clip-path-invalid-expected.txt
external/wpt/css/css-masking/parsing/clip-valid.html new failing tests: https://crrev.com/c/1058915/4/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/parsing/clip-valid-expected.txt
external/wpt/css/css-masking/parsing/clip-path-valid.html new failing tests: https://crrev.com/c/1058915/4/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/parsing/clip-path-valid-expected.txt
external/wpt/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-002.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-005.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-007.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-008.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-012.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-003.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-001.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-003.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-001.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-002.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-004.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-011.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-013.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-002.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-transform.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-003.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-009.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-005.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-002.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-003.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-001.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-005.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-006.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-dom-href.svg [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-css-transform-002.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-004.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-010.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-clip-rule-008.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-circle-006.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-shape-circle-003.svg [ Failure ]
external/wpt/css/css-masking/test-mask.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-006.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-shape-circle-004.svg [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-recursion-002.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-polygon-008.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-transform.svg [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-008.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-ellipse-007.html [ Failure ]
external/wpt/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-004.html [ Failure ]
external/wpt/css/css-masking/clip-path-svg-content/clip-path-shape-circle-005.svg [ Failure ]

This import contains upstream changes from d7f094475197eadee4e3a9a869b99d0fa9f857ec to d811a479537b9e54cefc7a3cffa39e790a5e4c9d:
Worklet: Remove outdated comment from WPT: https://github.com/w3c/web-platform-tests/commit/d811a479537b9e54cefc7a3cffa39e790a5e4c9d

 

Comment 1 by foolip@chromium.org, May 15 2018

These are all the failures in the initial import after https://chromium-review.googlesource.com/1057090

As mentioned in that issue, one Chrome-only failures is especially interesting:
https://wpt.fyi/css/css-masking/parsing/clip-path-invalid.html

Comment 2 by f...@opera.com, May 15 2018

A use counter [1] was added [2] for that particular case. Looks like usage is non-zero but low.

https://www.chromestatus.com/metrics/feature/timeline/popularity/2327
https://bugs.chromium.org/p/chromium/issues/detail?id=800307
Labels: Test-Layout OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2 Type-Bug
Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c53a1c24a0c6301dcc166d78c2b81e9ad0c9fc0

commit 8c53a1c24a0c6301dcc166d78c2b81e9ad0c9fc0
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu May 24 20:11:41 2018

Fix wpt/css/css-masking/parsing/clip-valid.html subtest

Percentages are not allowed in rect() (arguments are '<length> | auto'.)
Move the old test to clip-invalid.html and replace it with one that
doesn't use percentages.

Bug: 843084
Change-Id: I3cadd99da0d302ac5a0cd012450dd7ade233681c
Reviewed-on: https://chromium-review.googlesource.com/1071469
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561598}
[modify] https://crrev.com/8c53a1c24a0c6301dcc166d78c2b81e9ad0c9fc0/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/parsing/clip-invalid.html
[delete] https://crrev.com/1591ea17958c3eefbbd34c6ff3e9c6cfb0b901a0/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/parsing/clip-valid-expected.txt
[modify] https://crrev.com/8c53a1c24a0c6301dcc166d78c2b81e9ad0c9fc0/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/parsing/clip-valid.html

Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036419b142fcec0ffe1aeb6f7e9cfd508b04063e

commit 036419b142fcec0ffe1aeb6f7e9cfd508b04063e
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri May 25 15:17:48 2018

Fix errors in wpt/css/css-masking/* tests

clip-path-svg-content/clip-path-clip-rule-008.svg:
  Add missing reference (reference/clip-path-clip-rule-004-ref.svg).

clip-path-svg-content/clip-path-css-transform-002.svg:
  Adjust translation to match reference.

clip-path-svg-content/clip-path-dom-href.svg:
  Do setAttribute(...) on the correct <g>.

clip-path/clip-path-element-userSpaceOnUse-002.html:
  Shrink the clip-path so that it clips out the border, to match the
  reference.

clip-path/clip-path-ellipse-002.html:
clip-path/clip-path-ellipse-003.html:
clip-path/clip-path-ellipse-004.html:
clip-path/clip-path-ellipse-005.html:
  Adjust the description text so that it matches the reference.

clip-path/clip-path-ellipse-006.html:
  Use a different reference (reference/clip-path-ellipse-ref.html), and
  adjust the target <div> such that it matches the reference (replacing
  the red border with a margin.)

clip-path/clip-path-ellipse-007.html:
clip-path/clip-path-ellipse-008.html:
  Replace red border with a margin.

clip-path/clip-path-polygon-001.html:
clip-path/clip-path-polygon-002.html:
clip-path/clip-path-polygon-003.html:
  Adjust the description text so that it matches the reference.

clip-path/clip-path-polygon-004.html:
  Fix typo in assertion.

clip-path/clip-path-polygon-005.html:
  Adjust the description text so that it matches the reference.

Bug: 626703, 843084
Change-Id: I09c37cbe80ca3b82478bdd994ae027e9a72f280c
Reviewed-on: https://chromium-review.googlesource.com/1071529
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561880}
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path-svg-content/clip-path-css-transform-002.svg
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path-svg-content/clip-path-dom-href.svg
[add] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-004-ref.svg
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-element-userSpaceOnUse-002.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-002.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-003.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-004.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-005.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-006.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-007.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-ellipse-008.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-polygon-001.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-polygon-002.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-polygon-003.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-polygon-004.html
[modify] https://crrev.com/036419b142fcec0ffe1aeb6f7e9cfd508b04063e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-polygon-005.html

Sign in to add a comment