This is to independently track the broken node.js trybot when rolling icu. Current broken roll CL: https://chromium-review.googlesource.com/c/v8/v8/+/1058914 More comments and discussions on: https://chromium-review.googlesource.com/c/v8/v8/+/1038230 The other breakages with gcc are tracked in issue 843050 .
This is to independently track the broken node.js trybot when rolling icu. Current broken roll CL: https://chromium-review.googlesource.com/c/v8/v8/+/1061093 More comments and discussions on: https://chromium-review.googlesource.com/c/v8/v8/+/1038230 The other breakages with gcc are tracked in issue 843050 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/e7546473ac906fad7bb98363307080a3c9d3069a commit e7546473ac906fad7bb98363307080a3c9d3069a Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Tue May 15 10:40:36 2018 Move extern-C before __attribute__ declarations R=thomasanderson@chromium.org Bug: 843050 , 843073 Change-Id: I424c896118fa283568b65427b60eb1a8d37beee7 [modify] https://crrev.com/e7546473ac906fad7bb98363307080a3c9d3069a/third_party/libc++abi/cxa_demangle_stub.cc
Based on discussion in https://chromium-review.googlesource.com/c/v8/v8/+/1038230, ICU roll needs to be added to the blacklist in https://cs.chromium.org/chromium/build/scripts/slave/recipes/v8/auto_roll_v8_deps.py?q=auto_roll_v8&sq=package:chromium&l=46 until https://crbug.com/v8/7723 is resolved. I'll do that in https://crrev.com/c/1061234.
Also updated roll https://crrev.com/c/1061093 to exclude icu.
Roll landed. I'll TBR CL disabling icu rolls since Michael is OOO and to avoid another roll being blocked on it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/32e92c573863348da82109bc5e2a864d8f951887 commit 32e92c573863348da82109bc5e2a864d8f951887 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Wed May 16 11:01:39 2018 [V8] Temporarily stop rolling icu into v8 TBR=machenbach@chromium.org Bug: 843073 , v8:7723 Change-Id: I059890aa9d3bb1dbc8d13ef388e0da2423a5fe60 Reviewed-on: https://chromium-review.googlesource.com/1061234 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> [modify] https://crrev.com/32e92c573863348da82109bc5e2a864d8f951887/scripts/slave/README.recipes.md [modify] https://crrev.com/32e92c573863348da82109bc5e2a864d8f951887/scripts/slave/recipes/v8/auto_roll_v8_deps.py
I'd rather keep this open util we're able to roll ICU 61 and remove it from the blacklist again. @Yang: Should we have another stab at updating ICU on the node vee-eight-lkgr branch?
Sure, but it's issue v8:7723 tracking ICU upgrade? I though this issue was about unblocking auto-roller.
I was thinking issue v8:7723 is for a long term solution. This issues is for getting the current update through.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ea62a199bd1a79d880e6442d9397e151e459069f commit ea62a199bd1a79d880e6442d9397e151e459069f Author: Michael Achenbach <machenbach@chromium.org> Date: Fri May 18 08:48:43 2018 [V8] Clean up files on node.js builder TBR=sergiyb@chromium.org Bug: 843073 Change-Id: I1658307b08970d6036b57f413b7ba282f916e090 Reviewed-on: https://chromium-review.googlesource.com/1065734 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/experimental.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.py [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_tryserver_v8_v8_node_linux64_rel.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Win64___node_js_baseline.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/README.recipes.md [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_integration.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_baseline.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Linux64___node_js_integration.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Win64___node_js_integration.json [modify] https://crrev.com/ea62a199bd1a79d880e6442d9397e151e459069f/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Linux64___node_js_baseline.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48 commit b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48 Author: Michael Achenbach <machenbach@chromium.org> Date: Fri May 18 09:33:33 2018 [V8] Split make steps on node builder for better debugging TBR=sergiyb@chromium.org Bug: 843073 Change-Id: I2527acdf786d532ed6cd3d5dad623960be9a19ec Reviewed-on: https://chromium-review.googlesource.com/1065870 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.expected/experimental.json [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.py [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.expected/full_tryserver_v8_v8_node_linux64_rel.json [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/README.recipes.md [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_integration.json [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_baseline.json [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Linux64___node_js_integration.json [modify] https://crrev.com/b1a8e8ff5e1f86005cc73cf60155af9d1ff42b48/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Linux64___node_js_baseline.json
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e15a3fad38679588670d5b542e5cb4892a3dd2a0 commit e15a3fad38679588670d5b542e5cb4892a3dd2a0 Author: Jungshik Shin <jshin@chromium.org> Date: Fri May 18 11:52:19 2018 Update ICU to 61.1 ICU 61.1 was released in late March with CLDR 33. Arabic number format change in CLDR 33 requires a small adjustment in the test result. See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1041578 for details on ICU 61.1. NOTREECHECKS=true Bug: chromium:838383 , chromium:843073 Test: test262/intl402/*, intl/* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3778423b7dc67891767c95ea503e003013ae5b69 Reviewed-on: https://chromium-review.googlesource.com/1038230 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53251} [modify] https://crrev.com/e15a3fad38679588670d5b542e5cb4892a3dd2a0/DEPS [modify] https://crrev.com/e15a3fad38679588670d5b542e5cb4892a3dd2a0/test/mjsunit/intl-numberformat-formattoparts.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c8f9442c9771cead98c7de1f9343cc29c9ef87ac commit c8f9442c9771cead98c7de1f9343cc29c9ef87ac Author: Michael Achenbach <machenbach@chromium.org> Date: Fri May 18 12:15:53 2018 Revert "[V8] Temporarily stop rolling icu into v8" This reverts commit 32e92c573863348da82109bc5e2a864d8f951887. Reason for revert: ICU was upgraded. Original change's description: > [V8] Temporarily stop rolling icu into v8 > > TBR=machenbach@chromium.org > > Bug: 843073 , v8:7723 > Change-Id: I059890aa9d3bb1dbc8d13ef388e0da2423a5fe60 > Reviewed-on: https://chromium-review.googlesource.com/1061234 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> TBR=machenbach@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843073 , v8:7723 Change-Id: Ic9395ee9a9c321ab95b185b7624db88f74ba1c81 Reviewed-on: https://chromium-review.googlesource.com/1065816 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/c8f9442c9771cead98c7de1f9343cc29c9ef87ac/scripts/slave/README.recipes.md [modify] https://crrev.com/c8f9442c9771cead98c7de1f9343cc29c9ef87ac/scripts/slave/recipes/v8/auto_roll_v8_deps.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be commit ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be Author: Michael Achenbach <machenbach@chromium.org> Date: Tue May 22 07:32:36 2018 Revert "[V8] Clean up files on node.js builder" This reverts commit ea62a199bd1a79d880e6442d9397e151e459069f. Reason for revert: The bug was caused by something else. This clean up is too aggressive and causes full rebuilds. Original change's description: > [V8] Clean up files on node.js builder > > TBR=sergiyb@chromium.org > > Bug: 843073 > Change-Id: I1658307b08970d6036b57f413b7ba282f916e090 > Reviewed-on: https://chromium-review.googlesource.com/1065734 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> TBR=machenbach@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843073 Change-Id: I2306d7aede1c2a9bb07634fda0a89237c7cee5f5 Reviewed-on: https://chromium-review.googlesource.com/1068668 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/experimental.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.py [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_tryserver_v8_v8_node_linux64_rel.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Win64___node_js_baseline.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/README.recipes.md [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_integration.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_baseline.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Linux64___node_js_integration.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Win64___node_js_integration.json [modify] https://crrev.com/ba2e30152e3b6ba022f5914e37bc7e3f9d2b42be/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Linux64___node_js_baseline.json
Comment 1 by bugdroid1@chromium.org
, May 16 2018