Should not attempt to install terminal if there is no network |
||||
Issue descriptionChrome version: 68.0.3425.0 OS: Chrome OS 10663.0.0 Repro steps: 1. Have a device without terminal installed 2. Turn off internet 3. Try to setup terminal Expected: You get an error about needing a network connection to install terminal Actual: You get an error about something else.
,
May 21 2018
,
May 29 2018
,
Jun 18 2018
This is easy to check with NetworkChangeNotifier::IsOffline https://codesearch.chromium.org/chromium/src/net/base/network_change_notifier.h?type=cs&q=NetworkChangeNotifier&g=0&l=365 Do we care if it's on a Cellular network? My instinct says "No".
,
Jun 18 2018
Same. We already tell the user they are going to download lotsa data.
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2da5753ab77e42d9ae63471df2cab5f1d6543346 commit 2da5753ab77e42d9ae63471df2cab5f1d6543346 Author: Nicholas Verne <nverne@chromium.org> Date: Wed Jun 20 07:10:38 2018 Prevent Crostini install if offline. Since installing crostini involved downloading around 300MB, we prevent the install flow from proceeding if we're offline. Added a browser test with ExtraParts support. Bug: 843065 Change-Id: Ia0049d4ec30ac79c585d129e05aa2240eeecba09 Reviewed-on: https://chromium-review.googlesource.com/1107419 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568754} [modify] https://crrev.com/2da5753ab77e42d9ae63471df2cab5f1d6543346/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/2da5753ab77e42d9ae63471df2cab5f1d6543346/chrome/browser/ui/views/crostini/crostini_installer_view.cc [modify] https://crrev.com/2da5753ab77e42d9ae63471df2cab5f1d6543346/chrome/browser/ui/views/crostini/crostini_installer_view.h [modify] https://crrev.com/2da5753ab77e42d9ae63471df2cab5f1d6543346/chrome/browser/ui/views/crostini/crostini_installer_view_browsertest.cc
,
Jun 20 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by benwells@chromium.org
, May 15 2018Labels: -Restrict-View-Google