Gcc compile broken on v8 deps roll |
|||||
Issue description
,
May 15 2018
In case you have a fix, best would be to biggyback it onto the broken roll CL. The node builder can be fixed by omitting the icu roll. We'll solve that separately.
,
May 15 2018
I don't think we've had a roll attempt with this change yet. I poked it, we'll see how that goes.
,
May 15 2018
,
May 15 2018
I think we are not affected. This rolled fine https://webrtc-review.googlesource.com/c/src/+/76504
,
May 15 2018
,
May 15 2018
Looks like this is culprit: https://chromium.googlesource.com/chromium/buildtools/+/ae5162d61ffc7b32555675447842e2313f454673.
,
May 15 2018
The node.js builder that's also broken in the roll is now tracked independently in issue https://crbug.com/843073
,
May 15 2018
Looks like the issue is that `__attribute__((weak))` comes before `extern "C"`. If the order is reversed, GCC compiles the code just fine, although I get some linker errors locally.
,
May 15 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/buildtools/+/e7546473ac906fad7bb98363307080a3c9d3069a commit e7546473ac906fad7bb98363307080a3c9d3069a Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Tue May 15 10:40:36 2018 Move extern-C before __attribute__ declarations R=thomasanderson@chromium.org Bug: 843050 , 843073 Change-Id: I424c896118fa283568b65427b60eb1a8d37beee7 [modify] https://crrev.com/e7546473ac906fad7bb98363307080a3c9d3069a/third_party/libc++abi/cxa_demangle_stub.cc
,
May 16 2018
The node build is still broken and blocking the roll, but that's issue 843073 . |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by machenb...@chromium.org
, May 15 2018Owner: serg...@chromium.org
Status: Assigned (was: Untriaged)