New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 843040 link

Starred by 10 users

Issue metadata

Status: Duplicate
Merged: issue 645913
Owner: ----
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Hang Chrome while using File Open dialog to drag and drop

Reported by mike.tub...@gmail.com, May 15 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Open Facebook website and login
2. Start a messenger chat session with a friend
3. Click the image logo (bottom left) - OS file chooser UI opens
4. Navigate to a directory/folder with an image you want to send
5. Do NOT click (select) an image and hit 'Open', instead drag the image to the chat window.

What is the expected behavior?
Either (a) the file should be sent using the alternative method of dragging a file from the file open menue, or (b) this abuse of the file selection UI should be blocked.

What went wrong?
The file ends up in the messenger attachment, then Chrome stops responding.
Affects Chrome as a whole, have to use Ctrl-Alt-Del, task manager, kill Chrome and relaunch it to recover.

Crashed report ID: 

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? N/A 

Chrome version: 66.0.3359.139  Channel: n/a
OS Version: 10.0
Flash Version: 

Note entirely sure whether this is:
(a) a Chrome fault
(b) an OS issue with abuse of file selection UI
(c) a Facebook issue
but either way its Chrome that ends up hung/crashed.
 
Cc: sandeepkumars@chromium.org
Components: UI>Browser
Labels: Needs-Triage-M66
Tested the issue using #66.0.3359.139 on Win 10 as per the steps mentioned in original comment. No Browser Crash and hang is seen.

@Reporter: Could you please update Chrome to latest #66.0.3359.181 and check if you still face the issue? If so please attach a sample Crash I'd from chrome://crashes?

Thanks!!
Labels: Needs-Feedback
A team member discovered this while testing our project. I've narrowed it down to a very simple case. I will include the details I'm seeing now. I'd call it a hang rather than a crash, there is no crash report created as far as I can tell.

===================================

Chrome Version       : Version 70.0.3538.77 (Official Build) (64-bit)
OS Version: 10.0
URLs (if applicable) : https://jsfiddle.net/hu5wv0zx/
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox: OK
    IE/Edge: OK

What steps will reproduce the problem?
1. Visit https://jsfiddle.net/hu5wv0zx/ or use the simple repro case I have included below on your own file system.
2. Click the Choose File button to launch the open file dialog.
3. Drag a file from the open file dialog to the drop zone (bounded by orange border).
4. Click cancel button to close the open file dialog.
5. Chrome hangs. It's not 100%, you may have to try a few times or wait a while. It can be tricky to trigger sometimes but other times it happens every time.

What is the expected result?
Chrome exhibits normal drag and drop behaviour without hanging or prevents drag and drop from the open file dialog.

What happens instead of that?
Chrome occasionally hangs. Windows Event Viewer shows an Application Hang event for chrome.exe. Binary data on the event contains "Cross-thread Deadlock".

Please provide any additional information below. Attach a screenshot if possible.

I've run Chrome with logging enabled while reproducing this hang and the garbage collection kicks in with this log line when the hang occurs. I haven't run with logging with this very simple test case but can do so if you'd like to see the full log. Can also provide a process DMP upon request.
[38156:31456:1018/081155.054:VERBOSE1:thread_state.cc(1565)] [state:00007FFF53BBBDE0] CollectGarbage: time: 1ms stack: NoHeapPointersOnStack marking: AtomicMarking sweeping: LazySweeping reason: IdleGC

Very Simple Repro Case
======================
<!DOCTYPE html>
<html>
<body>
	<input type="file"/>
	<div style="width:1024px;height:768px;border:2px solid orange" ondrop="function(){}" ondragover="function(){}">
	dragon drop
	</div>
</body>
</html>

Labels: Stability-Sheriff-Desktop
Status: Untriaged (was: Unconfirmed)
I was able to reproduce this when I drop cursor_bug.html to the drop target. Other files didn't work for me.

Chrome 70.0.3538.77, Windows 10.

Adding Stability-Sheriff-Desktop to figure out the cause.
cursor_bug.html
132 bytes View Download
 Issue 901404  has been merged into this issue.
Summary: Hang/crash Chrome while using facebook messenger to send an image (was: Gang/crash Chrome while using facebook messenger to send an image)
Since we're changing things about the bug can we change the title to "Hang Chrome while using File Open dialog to drag and drop"? Seems to describe the issue better.

I'd also like to point out that the behaviour is intermittent, I've had this happen with PNGs, JPGs, FPLs (binary Foobar2000 playlist file), and DOCXs. Seems to happen pretty much regardless of file type.
Summary: Hang Chrome while using File Open dialog to drag and drop (was: Hang/crash Chrome while using facebook messenger to send an image)
Cc: brucedaw...@chromium.org
+ brucedawson. We've got a reproducible hang caused by drag-and-drop on Windows. Is this something your team could look at?
Is it the same as  crbug.com/645913 ? And  crbug.com/759848 ?

759848 has some extra analysis but the TL;DR is don't Join on COM threads.
Sounds like those bugs are the same behaviour to me.
[Stability Sheriff]  I suggest de-duping this bug and  Bug 759848  since they are all manifestations of the same root cause/deadlock.  If I don't hear any objections I'll do that later today.



Issue 903722 has been merged into this issue.
Cc: raymes@chromium.org
 Issue 424538  has been merged into this issue.
Labels: Hotlist-DesktopUIChecked
**UI mass Triage**

Mergedinto: 645913
Status: Duplicate (was: Untriaged)
Per comment #10 marking as a dup.
Labels: -Stability-Sheriff-Desktop

Sign in to add a comment