blink_heap_unittests HeapTest.LargeHashMap fails on many Android bots |
|||
Issue descriptionFor example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Lollipop%20Phone%20Tester/248 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Lollipop%20Tablet%20Tester/160 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%20Tablet%20Tester/150 It appears to either crash or time out. Presumably the devices don't have enough RAM to handle it.
,
May 15 2018
,
May 15 2018
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/496dcfd04594afefa8cc3641e835b5cc3af4193d commit 496dcfd04594afefa8cc3641e835b5cc3af4193d Author: Hans Wennborg <hans@chromium.org> Date: Tue May 15 08:44:13 2018 Disable HeapTest.LargeHashMap on Android Bug: 843032 Change-Id: I0aabddd2f0ae520fcd46a5c6532289547da7cde3 Reviewed-on: https://chromium-review.googlesource.com/1058796 Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558642} [modify] https://crrev.com/496dcfd04594afefa8cc3641e835b5cc3af4193d/third_party/blink/renderer/platform/heap/heap_test.cc
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c374c171733fe2f6ff6f90b78681da0a528da533 commit c374c171733fe2f6ff6f90b78681da0a528da533 Author: Keishi Hattori <keishi@chromium.org> Date: Wed May 16 01:54:11 2018 Oilpan: Reduce memory usage for HeapTest.MAYBE_LargeHashMap Test was intended to check if we can allocate a 134MB HashTable but it was allocating 800MB. This fixes the error in element size calculation, but because ReserveCapacityForSize allocates 2^(ceil(log2(size)) + 1) byte backing, we still allocate a 400MB backing. I've added a comment for that. Bug: 843032 Change-Id: I6b19a1e9cb58b6f2bfc4f1941fa8f67369f5e21c Reviewed-on: https://chromium-review.googlesource.com/1059234 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558921} [modify] https://crrev.com/c374c171733fe2f6ff6f90b78681da0a528da533/third_party/blink/renderer/platform/heap/heap_test.cc
,
Jul 24
|
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, May 15 2018