Improve FileManagerBrowserTest naming |
||||||
Issue descriptionFileManagerBrowserTest is a parameterized gtest, with names like the following, per test fixture instantiation: GroupPrefix/FileManagerBrowserTest/Test0 GroupPrefix/FileManagerBrowserTest/Test1 GroupPrefix/FileManagerBrowserTest/Test2 These names do not tell gardeners/sheriffs/us too much about what the test does. We could do much better here. Second, if a test is disabled in the C++ (say the middle one above), then the data for Test2 stops appearing on the flakiness dashboard, and starts appearing in Test/1. That is very very confusing. We should better name our tests with he underlying JS test name, to give them perma- names. Options such as Guestmode, Incognito, etc should be appended as option names.
,
May 15 2018
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75908631251d1624ba1422d69c35df67fbd7c161 commit 75908631251d1624ba1422d69c35df67fbd7c161 Author: Noel Gordon <noel@chromium.org> Date: Tue May 15 09:42:20 2018 FileManagerBrowserTest: replace std::tuple<> with TestCase std::tuple<> is not a good passenger to have on the great browser test renaming ship. Throw it overboard, and replace with TestCase: a struct to cargo all our test options into the future. Current options are the GuestMode and |test_name| so no change in test behavior here. Bug: 843030 Change-Id: I85636ae502aa1b46f434884eeafaa0b2c2dcadd2 Reviewed-on: https://chromium-review.googlesource.com/1057747 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558653} [modify] https://crrev.com/75908631251d1624ba1422d69c35df67fbd7c161/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2817a4f125c284c70e0e3e91a8b996427886c3ea commit 2817a4f125c284c70e0e3e91a8b996427886c3ea Author: Noel Gordon <noel@chromium.org> Date: Tue May 15 11:03:37 2018 Format FileManagerBrowserTest class per style Bug: 843030 Change-Id: Idf992fd81fa8647b13458ded9f47a83b8bc5a222 Reviewed-on: https://chromium-review.googlesource.com/1059099 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558660} [modify] https://crrev.com/2817a4f125c284c70e0e3e91a8b996427886c3ea/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b4c78e678687f8004bfdba41d4eb16bfb7c27f1 commit 6b4c78e678687f8004bfdba41d4eb16bfb7c27f1 Author: Noel Gordon <noel@chromium.org> Date: Tue May 15 11:33:44 2018 Remove NOT_IN_GUEST_MODE in TestCase calls: add one-arg constructor NOT_IN_GUEST_MODE is the default guest mode for a TestCase. Remove it in TestCase calls by adding an explicit, one-arg TestCase constructor (which is therefore NOT_IN_GUEST_MODE by default). No change in behavior, no new tests. Bug: 843030 Change-Id: Ib46f5f047c74c426d56ceacb1f6ab8334ccd88a7 Reviewed-on: https://chromium-review.googlesource.com/1059101 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558661} [modify] https://crrev.com/6b4c78e678687f8004bfdba41d4eb16bfb7c27f1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c16d8d1da2ca82ed9be6d58aa5cbc81d7b4fc1fe commit c16d8d1da2ca82ed9be6d58aa5cbc81d7b4fc1fe Author: Noel Gordon <noel@chromium.org> Date: Tue May 15 12:54:48 2018 Move TestCase constructor GuestMode argument to the back No change in behavior, no new tests. Bug: 843030 Change-Id: I7ee2385d419c637da4ced0491e50cde3ed6558b5 Reviewed-on: https://chromium-review.googlesource.com/1059367 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558674} [modify] https://crrev.com/c16d8d1da2ca82ed9be6d58aa5cbc81d7b4fc1fe/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b19b67626a11b30690dddae9a5d885632c99716 commit 9b19b67626a11b30690dddae9a5d885632c99716 Author: Noel Gordon <noel@chromium.org> Date: Tue May 15 14:18:36 2018 Add chain-able TestCase GuestMode helpers Now make TestCase have single-arg constructor only. Add InGuestMode(), InIncognito() helpers to deal with setting those modes. No change in behavior, no new tests. Bug: 843030 Change-Id: I315b114b7f3a1bd297a0db9916f7f1be1e968219 Reviewed-on: https://chromium-review.googlesource.com/1059493 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558695} [modify] https://crrev.com/9b19b67626a11b30690dddae9a5d885632c99716/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 15 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d038d7f8b09f5697f89ae0005e504d11d0b8e2b2 commit d038d7f8b09f5697f89ae0005e504d11d0b8e2b2 Author: Noel Gordon <noel@chromium.org> Date: Wed May 16 02:41:58 2018 WRAPPED_INSTANTIATE_TEST_CASE_P second arg is the test fixture class The second macro arg is the test fixture class, FileManagerBrowserTest here, so change the macro arg to say that. Update comment. Minor: add TODO about ditching the legacy event dispatch class. No-Presubmit: true Bug: 843030 Change-Id: Ia1695959aa28188d9d8de8dc6482ac86066a3074 Reviewed-on: https://chromium-review.googlesource.com/1059980 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558934} [modify] https://crrev.com/d038d7f8b09f5697f89ae0005e504d11d0b8e2b2/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6143852a9158d747ab7600795f6735e35c4872bf commit 6143852a9158d747ab7600795f6735e35c4872bf Author: Noel Gordon <noel@chromium.org> Date: Wed May 16 08:34:34 2018 Document integration test JS file used by each test fixture Minor: move some fixtures to improve grouping. Bug: 843030 Change-Id: Ibd8e763fc893474e152933ba57bd2cb4dc30da50 Reviewed-on: https://chromium-review.googlesource.com/1059638 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559013} [modify] https://crrev.com/6143852a9158d747ab7600795f6735e35c4872bf/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b2f15e81e6ff464f1a341ae9a264214e7cf6e08 commit 6b2f15e81e6ff464f1a341ae9a264214e7cf6e08 Author: Noel Gordon <noel@chromium.org> Date: Wed May 16 11:42:59 2018 FileManagerBrowserTest: move tasks-tests into one test fixture This creates Tasks/FileManagerBrowserTest. Move old fixtures into this new fixture. The old fixtures now go the way of the Dodo and Flakiness Dashboard will stop getting data from them. That's fine - the new test fixture provides the "tasks" test data. These test are not supported on mash: add mash test exclusions. Remove the "CanHandle type" comment: that bug was fixed. QuickView must still be excluded in my testing: retain its exclusion. Tbr: slangley No-Presubmit: true Bug: 843030 Change-Id: I7b3d9a1d3cd30d5934289ddc3a3ba0cd473246db Reviewed-on: https://chromium-review.googlesource.com/1060936 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559041} [modify] https://crrev.com/6b2f15e81e6ff464f1a341ae9a264214e7cf6e08/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/6b2f15e81e6ff464f1a341ae9a264214e7cf6e08/testing/buildbot/filters/mash.browser_tests.filter
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d8186ae26359882c208bf200dbc7ad5cc4610a2 commit 7d8186ae26359882c208bf200dbc7ad5cc4610a2 Author: Noel Gordon <noel@chromium.org> Date: Wed May 16 14:02:25 2018 FileManagerBrowserTest: group tabindex tests into one test fixture Remove FileManagerBrowserTestWithLegacyEventDispatch [1], and re-group the tabindex tests into one test fixture. The old fixtures go away and the Flakiness Dashboard will no longer get data from them. [1] FileManagerBrowserTest handles legacy event dispatch for any tests that contain "tabindex", see ShouldEnableLegacyEventDispatch. Mash: remove old TabIndex test exclusions from the Mash bot filter and add exclusion for the new TabIndex/FileManagerBrowserTest. Bug: 843030 Change-Id: I5aa45996ede4eccdc39ec2ba04d945e7b7f5032f Reviewed-on: https://chromium-review.googlesource.com/1061133 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559080} [modify] https://crrev.com/7d8186ae26359882c208bf200dbc7ad5cc4610a2/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/7d8186ae26359882c208bf200dbc7ad5cc4610a2/testing/buildbot/filters/mash.browser_tests.filter
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65cd71a7b08de646b6fc14a3992c0dfa7cae4ec6 commit 65cd71a7b08de646b6fc14a3992c0dfa7cae4ec6 Author: Noel Gordon <noel@chromium.org> Date: Thu May 17 08:21:26 2018 Change share_and_manage_dialog.js test case names These tests share a file/directory, or manage a hosted file/directory, on Drive only. Add "Drive" to their test names to make that clear. No change in behavior, no new tests. Bug: 843030 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id9c21021156b24eeceb01351d88cb22310584873 Reviewed-on: https://chromium-review.googlesource.com/1063513 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559454} [modify] https://crrev.com/65cd71a7b08de646b6fc14a3992c0dfa7cae4ec6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/65cd71a7b08de646b6fc14a3992c0dfa7cae4ec6/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js
,
May 17 2018
+loyso (who is adding new browser tests, thank you). As noted in #13 review, be aware that the all the integration test JS test names are in a global JS namespace called testcase [1]. So their "test names" must be unique names in that namespace (to avoid name collisions). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1063513#message-f39f125a702bd8a003d89c37b639aebec42fddfb
,
May 17 2018
Another reason for providing precise names is to help _other chrome developers_ work with and debug our tests [1]. See see what kylechar@ went through on crbug.com/837950#c15 for example. The test name does not show that it's a keyboard copy+paste test, sadly.
,
May 17 2018
I have uploaded https://chromium-review.googlesource.com/c/chromium/src/+/1063952 with the new test names. There's a new fixture name FilesAppBrowserTest too so it will easy to find on the Flakiness Dashboard [1]. [1] I'm sure you all remembered to search for "*/FileManagerBrowserTest"? Now you just search for "FilesApp". Tests pass locally for me. I won't run them on the bots until we are happy with the new test name (more below). Test speed is unchanged from when I started this bug: # time nice -20 xvfb-run -s "-screen 0 1024x1024x24" ./out/Release/browser_tests --gtest_filter="*FilesApp*" --test-launcher-jobs=50 IMPORTANT DEBUGGING NOTE: each test is run inside its own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with either --single_process (to run the test in one launcher/browser process) or --single-process (to do the above, and also run Chrome in single-process mode). Using sharding settings from environment. This is shard 0/1 Using 25 parallel jobs. [1/134] FileDisplay/FilesAppBrowserTest.Test/fileDisplayDownloads_GuestMode (15254 ms) [2/134] FileDisplay/FilesAppBrowserTest.Test/fileDisplayDownloads (15511 ms) [3/134] FileDisplay/FilesAppBrowserTest.Test/fileSearchNotFound (15496 ms) [4/134] FileDisplay/FilesAppBrowserTest.Test/fileDisplayMtp (15770 ms) [5/134] FileDisplay/FilesAppBrowserTest.Test/fileSearchCaseInsensitive (15772 ms) [6/134] FileDisplay/FilesAppBrowserTest.Test/fileDisplayDrive (16038 ms) [7/134] FileDisplay/FilesAppBrowserTest.Test/fileSearch (16034 ms) [8/134] CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads_GuestMode (16028 ms) [9/134] OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive (16292 ms) [10/134] OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads (16545 ms) [11/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive (16548 ms) [12/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads_GuestMode (16816 ms) [13/134] OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode (17083 ms) [14/134] CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads (17054 ms) [15/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads (17346 ms) [16/134] OpenImageFiles/FilesAppBrowserTest.Test/imageOpenDownloads_GuestMode (18119 ms) [17/134] OpenImageFiles/FilesAppBrowserTest.Test/imageOpenDownloads (18122 ms) [18/134] OpenImageFiles/FilesAppBrowserTest.Test/imageOpenDrive (18370 ms) [19/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeSingleFileDrive (21262 ms) [20/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeSingleFileDrive (21788 ms) [21/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioNoRepeatModeSingleFileDrive (21795 ms) [22/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeMultipleFileDrive (21792 ms) [23/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioAutoAdvanceDrive (22060 ms) [24/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioNoRepeatModeMultipleFileDrive (22342 ms) [25/134] OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeMultipleFileDrive (22572 ms) [26/134] KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode (16590 ms) [27/134] Delete/FilesAppBrowserTest.Test/deleteMenuItemNoEntrySelected (16321 ms) [28/134] KeyboardOperations/FilesAppBrowserTest.Test/keyboardCopyDownloads (17839 ms) [29/134] CreateNewFolder/FilesAppBrowserTest.Test/createFolderDrive (18383 ms) [30/134] KeyboardOperations/FilesAppBrowserTest.Test/keyboardCopyDownloads_GuestMode (17856 ms) [31/134] KeyboardOperations/FilesAppBrowserTest.Test/keyboardCopyDrive (17846 ms) [32/134] KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads (17060 ms) [33/134] KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDrive (17314 ms) [34/134] CreateNewFolder/FilesAppBrowserTest.Test/createFolderDownloads (19234 ms) [35/134] KeyboardOperations/FilesAppBrowserTest.Test/renameFileDrive (18098 ms) [36/134] KeyboardOperations/FilesAppBrowserTest.Test/renameFileDownloads (18375 ms) [37/134] KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDownloads (19166 ms) [38/134] KeyboardOperations/FilesAppBrowserTest.Test/renameFileDownloads_GuestMode (18651 ms) [39/134] KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDrive (19674 ms) [40/134] QuickView/FilesAppBrowserTest.Test/closeQuickView (17055 ms) [41/134] Delete/FilesAppBrowserTest.Test/deleteEntryWithToolbar (17326 ms) [42/134] KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDownloads_GuestMode (20199 ms) [43/134] QuickView/FilesAppBrowserTest.Test/openQuickView (17593 ms) [44/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCopyWithContextMenu (16791 ms) [45/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCopyWithoutChangingCurrent (16268 ms) [46/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCopyWithKeyboard_GuestMode (16526 ms) [47/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCutWithContextMenu (16532 ms) [48/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCopyWithKeyboard (17101 ms) [49/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCopyWithContextMenu_GuestMode (17318 ms) [50/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCutWithContextMenu_GuestMode (16529 ms) [51/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithContextMenu (16535 ms) [52/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirPasteWithContextMenu (16795 ms) [53/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirPasteWithoutChangingCurrent (16798 ms) [54/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCutWithKeyboard_GuestMode (17069 ms) [55/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirPasteWithContextMenu_GuestMode (17060 ms) [56/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCutWithKeyboard (17855 ms) [57/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithContextMenu_GuestMode (19162 ms) [58/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameToExisting (18366 ms) [59/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameToExisting_GuestMode (18099 ms) [60/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameToEmptyString_GuestMode (18643 ms) [61/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithKeyboard (19153 ms) [62/134] DriveSpecific/FilesAppBrowserTest.Test/driveOpenSidebarOffline (17844 ms) [63/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithKeyboard_GuestMode (19160 ms) [64/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithoutChangingCurrent (19155 ms) [65/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameToEmptyString (18904 ms) [66/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateWithKeyboard (18358 ms) [67/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateWithoutChangingCurrent (18366 ms) [68/134] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateWithContextMenu (18628 ms) [69/134] DriveSpecific/FilesAppBrowserTest.Test/driveAutoCompleteQuery (17580 ms) [70/134] DriveSpecific/FilesAppBrowserTest.Test/drivePressEnterToSearch (17322 ms) [71/134] DriveSpecific/FilesAppBrowserTest.Test/driveOpenSidebarSharedWithMe (18364 ms) [72/134] DriveSpecific/FilesAppBrowserTest.Test/drivePinFileMobileNetwork (18102 ms) [73/134] DriveSpecific/FilesAppBrowserTest.Test/driveClickFirstSearchResult (18104 ms) [74/134] Transfer/FilesAppBrowserTest.Test/transferFromDownloadsToDrive (18103 ms) [75/134] Transfer/FilesAppBrowserTest.Test/transferFromDriveToDownloads (18110 ms) [76/134] Traverse/FilesAppBrowserTest.Test/traverseDownloads_GuestMode (16790 ms) [77/134] ShareAndManageDialog/FilesAppBrowserTest.Test/manageHostedFileDrive (17068 ms) [78/134] Transfer/FilesAppBrowserTest.Test/transferFromSharedToDrive (20747 ms) [79/134] Transfer/FilesAppBrowserTest.Test/transferFromOfflineToDownloads (20735 ms) [80/134] ShareAndManageDialog/FilesAppBrowserTest.Test/manageFileDrive (17585 ms) [81/134] Traverse/FilesAppBrowserTest.Test/traverseDownloads (17330 ms) [82/134] ShareAndManageDialog/FilesAppBrowserTest.Test/shareFileDrive (17847 ms) [83/134] Transfer/FilesAppBrowserTest.Test/transferFromSharedToDownloads (20995 ms) [84/134] ShareAndManageDialog/FilesAppBrowserTest.Test/shareDirectoryDrive (18112 ms) [85/134] Transfer/FilesAppBrowserTest.Test/transferFromOfflineToDrive (21009 ms) [86/134] RestoreGeometry/FilesAppBrowserTest.Test/restoreGeometryMaximized (18365 ms) [87/134] RestorePrefs/FilesAppBrowserTest.Test/restoreSortColumn_GuestMode (21007 ms) [88/134] RestorePrefs/FilesAppBrowserTest.Test/restoreCurrentView (18627 ms) [89/134] SuggestAppDialog/FilesAppBrowserTest.Test/suggestAppDialog (18380 ms) [90/134] RestoreGeometry/FilesAppBrowserTest.Test/restoreGeometry (18915 ms) [91/134] RestorePrefs/FilesAppBrowserTest.Test/restoreCurrentView_GuestMode (19150 ms) [92/134] RestorePrefs/FilesAppBrowserTest.Test/restoreSortColumn (21281 ms) [93/134] RestoreGeometry/FilesAppBrowserTest.Test/restoreGeometry_GuestMode (19942 ms) [94/134] Tasks/FilesAppBrowserTest.Test/executeDefaultTaskDownloads (18097 ms) [95/134] Tasks/FilesAppBrowserTest.Test/executeDefaultTaskDrive (18104 ms) [96/134] Traverse/FilesAppBrowserTest.Test/traverseDrive (18893 ms) [97/134] Tasks/FilesAppBrowserTest.Test/executeDefaultTaskDownloads_GuestMode (18628 ms) [98/134] Tasks/FilesAppBrowserTest.Test/defaultTaskDialogDownloads_GuestMode (18363 ms) [99/134] Tasks/FilesAppBrowserTest.Test/defaultTaskDialogDrive (18363 ms) [100/134] Tasks/FilesAppBrowserTest.Test/defaultTaskDialogDownloads (18623 ms) [101/134] TabIndex/FilesAppBrowserTest.Test/tabindexSearchBoxFocus (17862 ms) [102/134] Tasks/FilesAppBrowserTest.Test/genericTaskAndNonGenericTask (18629 ms) [103/134] TabIndex/FilesAppBrowserTest.Test/tabindexFocusDownloads (17844 ms) [104/134] TabIndex/FilesAppBrowserTest.Test/tabindexFocusDownloads_GuestMode (17849 ms) [105/134] TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads (17314 ms) [106/134] TabIndex/FilesAppBrowserTest.Test/tabindexFocusDirectorySelected (17847 ms) [107/134] SortColumns/FilesAppBrowserTest.Test/sortColumns_GuestMode (18366 ms) [108/134] Tasks/FilesAppBrowserTest.Test/genericTaskIsNotExecuted (19154 ms) [109/134] TabIndex/FilesAppBrowserTest.Test/tabindexOpenDialogDownloads_GuestMode (17856 ms) [110/134] TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDrive (17845 ms) [111/134] SortColumns/FilesAppBrowserTest.Test/sortColumns (18891 ms) [112/134] TabIndex/FilesAppBrowserTest.Test/tabindexFocus (18900 ms) [113/134] TabIndex/FilesAppBrowserTest.Test/tabindexOpenDialogDownloads (18638 ms) [114/134] TabIndex/FilesAppBrowserTest.Test/tabindexOpenDialogDrive (18896 ms) [115/134] FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts (20471 ms) [116/134] FileDialog/FilesAppBrowserTest.Test/openFileDialogUnload (16273 ms) [117/134] FolderShortcuts/FilesAppBrowserTest.Test/addRemoveFolderShortcuts (20739 ms) [118/134] GridView/FilesAppBrowserTest.Test/showGridViewDownloads (17329 ms) [119/134] GridView/FilesAppBrowserTest.Test/showGridViewDownloads_GuestMode (17328 ms) [120/134] TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads_GuestMode (20738 ms) [121/134] FileDialog/FilesAppBrowserTest.Test/openFileDialogDownloads_GuestMode (21786 ms) [122/134] FileDialog/FilesAppBrowserTest.Test/openFileDialogDownloads (22823 ms) [123/134] FileDialog/FilesAppBrowserTest.Test/openFileDialogDownloads_Incognito (21769 ms) [124/134] FileDialog/FilesAppBrowserTest.Test/openFileDialogDrive (22035 ms) [125/134] FileDialog/FilesAppBrowserTest.Test/openFileDialogDrive_Incognito (22565 ms) [126/134] GearMenu/FilesAppBrowserTest.Test/showPasteIntoCurrentFolder (15477 ms) [127/134] GridView/FilesAppBrowserTest.Test/showGridViewDrive (16521 ms) [128/134] GearMenu/FilesAppBrowserTest.Test/toogleGoogleDocsDrive (16002 ms) [129/134] Providers/FilesAppBrowserTest.Test/requestMountMultipleMounts (16522 ms) [130/134] Providers/FilesAppBrowserTest.Test/requestMountSourceDevice (16529 ms) [131/134] GearMenu/FilesAppBrowserTest.Test/showHiddenFilesDownloads (16521 ms) [132/134] GearMenu/FilesAppBrowserTest.Test/showHiddenFilesDrive (16520 ms) [133/134] Providers/FilesAppBrowserTest.Test/requestMount (17043 ms) [134/134] Providers/FilesAppBrowserTest.Test/requestMountSourceFile (17573 ms) SUCCESS: all tests passed. real 1m50.639s user 20m18.668s sys 1m56.128s ... or 1 min, 50 secs by my watch. You can see all the new test names. If we want to change them, now would be the time to make those changes. The is a clear dichotomy b/w Directory or Folder, for example. Perhaps we should choose one, but maybe I'm past caring about it ... Change is up for review, and anyone can review.
,
May 18 2018
loyso's change has landed crrev/559750, sasha's change has landed crrev.com/559805 so syno-ing up my client ...
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b294d0c43be3ae928447a28746f4ec1d23049643 commit b294d0c43be3ae928447a28746f4ec1d23049643 Author: Noel Gordon <noel@chromium.org> Date: Fri May 18 08:02:32 2018 Rename FileManagerBrowserTest: add JS test case names Change test fixture name to FilesAppBrowserTest. Also, add JS testcase name, plus modes, to the end of GTEST test name (which is shown on the Flakiness Dashboard). That's all GTEST allows, and it is strict re the character used to combine string names: '_' only. FilesAppBrowserTest, the new fixture name, is used to decouple all the re-named tests from the old fixture name, FileManagerBrowserTest, when searching the Flakiness Dashboard [1]. Update the Mash bot filter exclusion list for the new fixture name and add TODO(me): remove the old Mash FileManagerBrowserTest entries. [1] Keeping FileManagerBrowserTest would cause developer confusion. Bug: 843030 ,836254 No-presubmit: true Change-Id: I46318d34ce5132155db6d0e792e54a579b8e5c5c Reviewed-on: https://chromium-review.googlesource.com/1063952 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559833} [modify] https://crrev.com/b294d0c43be3ae928447a28746f4ec1d23049643/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/b294d0c43be3ae928447a28746f4ec1d23049643/testing/buildbot/filters/mash.browser_tests.filter
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b01cc1bde4f52886cfd9f20a21c511274ed873d commit 1b01cc1bde4f52886cfd9f20a21c511274ed873d Author: Noel Gordon <noel@chromium.org> Date: Mon May 21 07:37:46 2018 Remove Mash FileManageBrowserTest exclusions FileManagerBrowserTest was renamed in crrev.com/559833 so there are no FileManagerBrowserTests anymore. Remove their Mash bot filter excludes (and group the Files.App-related tests together) in the file. Bug: 843030 ,836254 Change-Id: I865e22f6e9d762b9766a192ec038860eb591f01c Reviewed-on: https://chromium-review.googlesource.com/1067317 Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#560241} [modify] https://crrev.com/1b01cc1bde4f52886cfd9f20a21c511274ed873d/testing/buildbot/filters/mash.browser_tests.filter
,
May 21 2018
,
May 21 2018
\o/! :D |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by noel@chromium.org
, May 15 2018