"org.chromium.chrome.browser.webapps.TrustedWebActivityTest#testNavigationCallbacks" is flaky |
||
Issue description"org.chromium.chrome.browser.webapps.TrustedWebActivityTest#testNavigationCallbacks" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXQsSBUZsYWtlIlJvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIud2ViYXBwcy5UcnVzdGVkV2ViQWN0aXZpdHlUZXN0I3Rlc3ROYXZpZ2F0aW9uQ2FsbGJhY2tzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/470798de6eb0526a6d0292eacebb1015a0661357 commit 470798de6eb0526a6d0292eacebb1015a0661357 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue May 15 21:29:20 2018 Disable flaky testNavigationCallbacks test. Bug: 842929 Change-Id: I2e4f67cd3ae1620f6c4cb6fdfeb2a99139168f04 Tbr: mvanouwerkerk@chromium.org Tbr: tedchoc@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1060119 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#558839} [modify] https://crrev.com/470798de6eb0526a6d0292eacebb1015a0661357/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/TrustedWebActivityTest.java
,
May 15 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, May 15 2018Owner: mvanouwe...@chromium.org
Status: Assigned (was: Untriaged)
mvanouwerkerk@ could you PTAL (as the author of the test)? I'll put together a CL that disables the test. java.util.concurrent.TimeoutException: waitForCallback timed out! at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191) at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:227) at org.chromium.chrome.browser.webapps.TrustedWebActivityTest.testNavigationCallbacks(TrustedWebActivityTest.java:150) Line 150 is here: // Start two page loads, triggering navigation aborted and finished events. ChromeTabUtils.waitForTabPageLoadStart(tab, () -> runOnUiThreadBlocking(() -> { tab.loadUrl(new LoadUrlParams(mTestPage2, PageTransition.LINK)); }), CallbackHelper.WAIT_TIMEOUT_SECONDS); ChromeTabUtils.waitForTabPageLoadStart(tab, () -> runOnUiThreadBlocking(() -> { tab.loadUrl(new LoadUrlParams(mTestPage3, PageTransition.LINK)); }), CallbackHelper.WAIT_TIMEOUT_SECONDS); HERE -> abortedCallback.waitForCallback(0); <- HERE (line 150) finishedCallback.waitForCallback(1); assertEquals(mTestPage3, tab.getUrl());