Feedback of screenshot uploading script |
|
Issue descriptionI have used this script recently, here are my feedback: 1) If the screenshot has been uploaded successfully but failed to attach to CL. It will be awesome if the script could store the SHA1 somewhere else so that re-run won't re-upload the pictures. 2) The script is slow if there're lots of pictures . Some screenshot might contains multiple string but I have to upload them multiple times for each string. It will be awesome if it's uploaded only once. (Detect duplicated pictures) 3) Chrome vs Chromium. Most of time, the difference is tiny. Rebuild Chrome to capture screenshot seems lots of work. I don't have a good suggestion for this. But hopefully there is a better solution here. 4) Right now, there is only one SHA1 the file. It's hard for ppl to know if it's the right picture. It will be awesome if there is a google drive link I could take a look.
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e81e468d66fb5e2b33470a2a16beeb49d702b99b commit e81e468d66fb5e2b33470a2a16beeb49d702b99b Author: Mustafa Emre Acer <meacer@chromium.org> Date: Tue Jul 31 17:33:46 2018 Use 10 threads instead of 1 while uploading screenshots Bug: 842913 Change-Id: I834c962a21faeb53cb64acb4a4202cf7cfe0af9e Reviewed-on: https://chromium-review.googlesource.com/1149185 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#579457} [modify] https://crrev.com/e81e468d66fb5e2b33470a2a16beeb49d702b99b/tools/translation/upload_screenshots.py |
|
►
Sign in to add a comment |
|
Comment 1 by mea...@chromium.org
, May 14 2018