New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842908 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

WebUI - Downloads: Ripple is very close to corner

Project Member Reported by hcarmona@chromium.org, May 14 2018

Issue description

What steps will reproduce the problem?
1. Download some files
2. Navigate to chrome://downloads

Notice ripple location in screenshot. Ripple is touching the edges of the card.
 
ripple-issie.png
9.7 KB View Download

Comment 1 by dpa...@chromium.org, May 14 2018

Components: UI>Browser>Downloads
Labels: Needs-Milestone
Labels: M-68 FoundIn-68 Target-68
Able to reproduce the issue on Win 10, Debian Rodette, Mac 10.13.3 with chrome stable #66.0.3359.181, Canary #68.0.3430.0 and also in earlier version M60- #60.0.3072.0

This is a non-regression issue, hence marking it as Untriaged

Attaching the screen-cast for reference
842908.mp4
260 KB View Download
Status: Untriaged (was: Unconfirmed)

Comment 5 by dpa...@chromium.org, May 16 2018

@Hector: Is this different than  issue 842121  ?
Labels: OS-Chrome OS-Mac OS-Windows
Yes, this issue was created b/c Scott was concerned that the ripple being against the corners of the card looks a bit odd. Added Namrata as owner so she can comment on next steps from a design POV
Status: Assigned (was: Untriaged)
I think to fix this we would need to move the position of the X by 8px from the top and 8px from the right.
Attaching screenshot.
Screen Shot 2018-07-03 at 4.18.28 PM.png
50.8 KB View Download
Additionally reduce the size of the cross from 32x32 to 16x16px
Owner: ----
Status: Available (was: Assigned)
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2a892ed06acbe22c04d10c91ccd4101c2bb67b6

commit f2a892ed06acbe22c04d10c91ccd4101c2bb67b6
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Jul 25 00:39:36 2018

Downloads: fix x-button spacing

Bug:  842908 
Change-Id: I0487199b47488c741ca360f5c462ac46fcb8b487
Reviewed-on: https://chromium-review.googlesource.com/1149067
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577749}
[modify] https://crrev.com/f2a892ed06acbe22c04d10c91ccd4101c2bb67b6/chrome/browser/resources/md_downloads/item.html

Status: Fixed (was: Started)
Labels: TE-Verified-M70 TE-Verified-70.0.3503.0
Able to reproduce this issue on reported version hence verifying the fix on latest canary 70.0.3503.0 using Mac 10.13.3, Windows 10 and debian.

Now close icon & ripple is not close to corner . Attaching screencast for reference.

As fix is working as expected adding Verified labels.

Thanks!
build with fix_Downloads.webm
3.9 MB View Download

Sign in to add a comment