WebUI - Downloads: Ripple is very close to corner |
||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Download some files 2. Navigate to chrome://downloads Notice ripple location in screenshot. Ripple is touching the edges of the card.
,
May 15 2018
,
May 16 2018
Able to reproduce the issue on Win 10, Debian Rodette, Mac 10.13.3 with chrome stable #66.0.3359.181, Canary #68.0.3430.0 and also in earlier version M60- #60.0.3072.0 This is a non-regression issue, hence marking it as Untriaged Attaching the screen-cast for reference
,
May 16 2018
,
May 16 2018
@Hector: Is this different than issue 842121 ?
,
May 16 2018
Yes, this issue was created b/c Scott was concerned that the ripple being against the corners of the card looks a bit odd. Added Namrata as owner so she can comment on next steps from a design POV
,
Jun 7 2018
,
Jul 3
I think to fix this we would need to move the position of the X by 8px from the top and 8px from the right. Attaching screenshot.
,
Jul 12
Additionally reduce the size of the cross from 32x32 to 16x16px
,
Jul 24
,
Jul 24
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2a892ed06acbe22c04d10c91ccd4101c2bb67b6 commit f2a892ed06acbe22c04d10c91ccd4101c2bb67b6 Author: Scott Chen <scottchen@chromium.org> Date: Wed Jul 25 00:39:36 2018 Downloads: fix x-button spacing Bug: 842908 Change-Id: I0487199b47488c741ca360f5c462ac46fcb8b487 Reviewed-on: https://chromium-review.googlesource.com/1149067 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577749} [modify] https://crrev.com/f2a892ed06acbe22c04d10c91ccd4101c2bb67b6/chrome/browser/resources/md_downloads/item.html
,
Jul 25
,
Jul 26
Able to reproduce this issue on reported version hence verifying the fix on latest canary 70.0.3503.0 using Mac 10.13.3, Windows 10 and debian. Now close icon & ripple is not close to corner . Attaching screencast for reference. As fix is working as expected adding Verified labels. Thanks! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dpa...@chromium.org
, May 14 2018