[VR Browsing] dismissing keyboard doesn't return user to VR browsing |
||||
Issue descriptionChrome Version: 68.0.3427.0 OS: Android N Device: 68.0.3427.0 What steps will reproduce the problem? (1) Enter VR browsing (2) Click in Omnibox to bring up keyboard (3) Click on the bottom right button on the keyboard which is the dismiss keyboard button. What is the expected result? User is returned to browsing mode. What happens instead? User remains in Omnibox edit mode but without the keyboard showing.
,
May 23 2018
,
May 23 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/564be974ba354505d1fde671c95622aefeae5c87 commit 564be974ba354505d1fde671c95622aefeae5c87 Author: Christopher Grant <cjgrant@chromium.org> Date: Wed May 23 20:48:48 2018 VR: Close omnibox when the keyboard is explicitly dismissed Usually, the keyboard disappears because the focus requiring it is lost. But for the omnibox, if the keyboard is explicitly dismissed with the on-keyboard button, and omnibox focus is lost, we should exit omnibox edit mode. BUG= 842898 R=bshe Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I36ec30f3a6e430a5b412b680258463afca9b8c06 Reviewed-on: https://chromium-review.googlesource.com/1070528 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561248} [modify] https://crrev.com/564be974ba354505d1fde671c95622aefeae5c87/chrome/browser/vr/ui_scene_creator.cc
,
May 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cjgrant@chromium.org
, May 22 2018Status: Assigned (was: Untriaged)