Stack Trace using from ffmpeg_demuxer when building w/o is_chrome_branded. |
||||||
Issue descriptionChrome Version: 68.0.3427.0 (Developer Build) OS: Android 8.1 Pixel 2 XL What steps will reproduce the problem? (1) Build a clean clank w/o the is_chrome_branded flag (2) Load https://www.quirksmode.org/html5/tests/video.html (3) Aw Snap What is the expected result? Page loads but restricted codec videos don't play What happens instead? Page loads for a second and then Aw, Snap! message appears in logcat: 05-14 10:16:12.135 18521 18548 F chromium: [FATAL:ffmpeg_demuxer.cc(719)] Check failed: false. Proprietary codecs not enabled.
,
May 14 2018
Already fixed here: https://chromium.googlesource.com/chromium/src/+/658e783ea9536e7113cdaf441f4cea6e03f97347
,
May 15 2018
Do we know why we started hitting this, though? The NOTREACHED() has been there for four years. [1] Was this perhaps introduced by the change to build MP4 support by default? Is the ifdef perhaps wrong? [1] https://chromium.googlesource.com/chromium/src/+blame/b88e5e3db62393f232edbcb13699c6da3fc03a04/media/filters/ffmpeg_demuxer.cc#719
,
May 15 2018
The behavior now seems to be that we don't crash but the video tries to play (green background). Should it refuse to play like the Ogg/Theora video (also on the page) refuses?
,
May 15 2018
Yes, it should refuse to play. Something must have changed recently. I'm not sure where things changed, but AVDA and MCVD should gate the supported h264 profiles based on PROPRIETARY_CODECS.
,
May 15 2018
Should this be re-opened then?
,
May 15 2018
I'll send a patch since Frank is overloaded right now.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0482d6d1273d9739377f47fc9be7a565ddf9a0a4 commit 0482d6d1273d9739377f47fc9be7a565ddf9a0a4 Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue May 15 20:47:29 2018 Protect h264, hevc hw decode support behind USE_PROPRIETARY_CODECS. This ensures they trigger a playback failure instead of green frames. BUG= 842890 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibe27767c5f4779d7b9d4ebecb74f442bf0701b15 Reviewed-on: https://chromium-review.googlesource.com/1060237 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558826} [modify] https://crrev.com/0482d6d1273d9739377f47fc9be7a565ddf9a0a4/media/gpu/android/android_video_decode_accelerator.cc [modify] https://crrev.com/0482d6d1273d9739377f47fc9be7a565ddf9a0a4/media/gpu/android/media_codec_video_decoder.cc
,
May 15 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60ec1e640d6aa7552e30a120ac5c3de475da91a3 commit 60ec1e640d6aa7552e30a120ac5c3de475da91a3 Author: Dale Curtis <dalecurtis@chromium.org> Date: Wed May 16 22:33:04 2018 Don't attempt WebRTC H264 test w/o proprietary codecs. Fixes broken ToTAndroidCFI bot after http://crrev.com/558826. BUG= 842890 TEST=none TBR=emircan Change-Id: I1aba2e491b34d71910430bfd4d2d6cba55045889 Reviewed-on: https://chromium-review.googlesource.com/1062802 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559316} [modify] https://crrev.com/60ec1e640d6aa7552e30a120ac5c3de475da91a3/content/browser/webrtc/webrtc_browsertest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by crouleau@chromium.org
, May 14 2018Owner: hubbe@chromium.org
Status: Assigned (was: Untriaged)