New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842876 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Stale buildbot bots appear in LUCI

Project Member Reported by ynovikov@chromium.org, May 14 2018

Issue description

We have removed all GPU.FYI buildbot bots and even master.chromium.gpu.fyi

However,
https://ci.chromium.org/search?q=chromium.gpu.fyi
still lists:
GPU FYI Win Builder
GPU FYI Win Builder (dbg)
GPU FYI Win Clang Builder (dbg)
GPU FYI Win dEQP Builder
GPU FYI Win x64 Builder
GPU FYI Win x64 Builder (dbg)
GPU FYI Win x64 dEQP Builder
Win10 FYI Debug (NVIDIA)
Win10 FYI Exp Release (NVIDIA)
Win10 FYI Release (Intel HD 630)
Win10 FYI Release (NVIDIA)
Win10 FYI dEQP Release (NVIDIA)
Win7 FYI Debug (AMD)
Win7 FYI Debug (NVIDIA)
Win7 FYI Release (AMD)
Win7 FYI Release (NVIDIA)
Win7 FYI dEQP Release (AMD)
Win7 FYI x64 Debug (NVIDIA)
Win7 FYI x64 Release (NVIDIA)
Win7 FYI x64 dEQP Release (NVIDIA)

This confuses other tools, for example https://sheriff-o-matic.appspot.com/chromium.gpu.fyi# reports that "chromium.gpu.fyi.Win7 FYI Debug (NVIDIA) is offline."
 

Comment 1 by kbr@chromium.org, May 14 2018

Cc: seanmccullough@chromium.org
Components: Infra>Sheriffing>SheriffOMatic
Not sure whether this is because we forgot to do a final shutdown of the chromium.gpu.fyi master, or if it's expected that these machines will show up in this place forever and that Sheriff-O-Matic needs to be updated somehow.

Labels: Milestone-Data
Status: Available (was: Unconfirmed)
GPU.FYI has a custom gatekeeper tree config IIRC, so we need to update it to reflect these changes.
Cc: cwallez@chromium.org
Non-Win bots were gone from this list after we did master.chromium.gpu.fyi restarts. If there isn't a simpler way to clean this up, maybe we need to revert removal of master.chromium.gpu.fyi and restart it.
On the Sheriff-o-Matic side, all we need to do is update a config file. So if stale alerts on SoM is the only place you have issues, you don't need a master restart.

Comment 5 by kbr@chromium.org, May 14 2018

Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Assigning to Ryan based on results from standup meeting.

Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a21133165b11aa398f6c8aea4da02cdb76dfce7a

commit a21133165b11aa398f6c8aea4da02cdb76dfce7a
Author: Ryan Tseng <hinoka@google.com>
Date: Tue May 15 23:04:39 2018

[milo] Don't return buildbot builders for masters that are turned down.

Bug:  842876 
Change-Id: I69161a5c331ad3924edcfa60f5fee57448236867
Reviewed-on: https://chromium-review.googlesource.com/1060466
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/a21133165b11aa398f6c8aea4da02cdb76dfce7a/milo/buildsource/buildbot/buildstore/master.go
[modify] https://crrev.com/a21133165b11aa398f6c8aea4da02cdb76dfce7a/milo/buildsource/buildbot/master_test.go

Comment 7 by hinoka@chromium.org, May 22 2018

Status: Fixed (was: Assigned)

Sign in to add a comment