New issue
Advanced search Search tips

Issue 842846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add ScrollUpdate/Begin metrics that is containing all scrolls regardless of the touch or wheel

Project Member Reported by nzolghadr@chromium.org, May 14 2018

Issue description

We need an overall metric for the health of the scrolling which should include all the scrolling cases regardless of the means.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882d5657487ece7998cad1014d6430914c121649

commit 882d5657487ece7998cad1014d6430914c121649
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue May 15 18:05:02 2018

Add an overall metric for scrolling via touch/wheel

Measure the scrolling performance regardless of
whether touch or wheel input triggered the scrolling.

Bug:  842846 
Change-Id: I04750f3537f4da326e9a2f3c0e16e895bc696c2a
Reviewed-on: https://chromium-review.googlesource.com/1059583
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558774}
[modify] https://crrev.com/882d5657487ece7998cad1014d6430914c121649/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/882d5657487ece7998cad1014d6430914c121649/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/882d5657487ece7998cad1014d6430914c121649/ui/latency/latency_histogram_macros.h
[modify] https://crrev.com/882d5657487ece7998cad1014d6430914c121649/ui/latency/latency_tracker.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8daf4c92a2955d3b4bc4bfd672d0c12ab4e0524f

commit 8daf4c92a2955d3b4bc4bfd672d0c12ab4e0524f
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Mon May 28 19:05:17 2018

Revert back the max bucket of input metrics to 1s

After landing
https://chromium-review.googlesource.com/c/chromium/src/+/1059583
as UMA pipeline doesn't support different bucket ranges over time
it failed to process the whole data in Canary and Dev.
This change reverts the bucket range change of the previous commit
to make sure this doesn't get to the stable data.

Bug:  842846 
Change-Id: I26da5fd4a86a81601cb445d211745ed8b6d2eb5c
Reviewed-on: https://chromium-review.googlesource.com/1075297
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562295}
[modify] https://crrev.com/8daf4c92a2955d3b4bc4bfd672d0c12ab4e0524f/ui/latency/latency_histogram_macros.h
[modify] https://crrev.com/8daf4c92a2955d3b4bc4bfd672d0c12ab4e0524f/ui/latency/latency_tracker.cc

Labels: Merge-Request-68 MERGE
Status: Started (was: Fixed)
Project Member

Comment 6 by sheriffbot@chromium.org, May 29 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add appropriate impacted OS. 
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: M-68 ReleaseBlock-Beta
Labels: -Merge-Review-68 Merge-Approved-68
Branch:3440
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b36d432403092360dbe6099cb5415aacc964f5

commit f5b36d432403092360dbe6099cb5415aacc964f5
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Mon Jun 04 14:27:37 2018

Revert back the max bucket of input metrics to 1s

After landing
https://chromium-review.googlesource.com/c/chromium/src/+/1059583
as UMA pipeline doesn't support different bucket ranges over time
it failed to process the whole data in Canary and Dev.
This change reverts the bucket range change of the previous commit
to make sure this doesn't get to the stable data.

Bug:  842846 
Change-Id: I26da5fd4a86a81601cb445d211745ed8b6d2eb5c
Reviewed-on: https://chromium-review.googlesource.com/1075297
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562295}(cherry picked from commit 8daf4c92a2955d3b4bc4bfd672d0c12ab4e0524f)
Reviewed-on: https://chromium-review.googlesource.com/1085247
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#134}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/f5b36d432403092360dbe6099cb5415aacc964f5/ui/latency/latency_histogram_macros.h
[modify] https://crrev.com/f5b36d432403092360dbe6099cb5415aacc964f5/ui/latency/latency_tracker.cc

Status: Fixed (was: Started)

Sign in to add a comment