New issue
Advanced search Search tips

Issue 842803 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Offline item : Set display name correctly in the backend.

Project Member Reported by shaktisahu@chromium.org, May 14 2018 
Currently we derive the display name for offline pages at the front-end from the page url/hostname. We have this logic repeated at multiple places (notification, download home and download infobar controller(CL in-progress)).
 We should instead consolidate this logic in the backend and set it as the "title".

Downloads will also set the "title" after migration to offline item.
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c83af60d45ca717280747379f320fe83f86d1040

commit c83af60d45ca717280747379f320fe83f86d1040
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Mon May 21 22:33:21 2018

Offline Item : Set title correctly at the offline pages backend

This CL consolidates the logic for determining the display name
 for offline pages in the backend. Earlier we were doing this
in the front-end at multiple places (e.g. download home,
notifications). With this change, we will set it as title
of the offline item in the backend itself. Downloads will also
follow a similar path after refactor to use offline items.

BUG= 842803 

Change-Id: I2c1a964f49f90fe5f145e5e7df95783ab6b3d269
Reviewed-on: https://chromium-review.googlesource.com/1054361
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560380}
[modify] https://crrev.com/c83af60d45ca717280747379f320fe83f86d1040/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
[modify] https://crrev.com/c83af60d45ca717280747379f320fe83f86d1040/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
[modify] https://crrev.com/c83af60d45ca717280747379f320fe83f86d1040/chrome/browser/offline_pages/android/downloads/offline_page_notification_bridge.cc
[modify] https://crrev.com/c83af60d45ca717280747379f320fe83f86d1040/components/offline_pages/core/downloads/offline_item_conversions.cc

Comment 2 by shaktisahu@chromium.org, May 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment