New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842801 link

Starred by 2 users
Status: Assigned
Owner:
petewil@chromium.org
Cc:
█ chili@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

testSavePageNoOrigin fails sometimes when P2P sharing flag turned on.

Project Member Reported by petewil@chromium.org, May 14 2018 
Enabling the 'OfflinePagesSharing' feature causes a test failure.

We believe that this happens when attempting to copy the saved file to a public location.  

It could be caused by:
1) Lack of public write permission for unit tests
2) Being out of space in the public dir
3) Target dir in use by system
4) File already exists.

Find out which of these is happening, and decide how to fix the code to prevent the test from failing.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b692f1d7ac9532e7176d521b89927ed128007331

commit b692f1d7ac9532e7176d521b89927ed128007331
Author: Pete Williamson <petewil@chromium.org>
Date: Tue Jun 26 22:24:51 2018

Track problems moving files with histograms and logging

Bug: 842801
Change-Id: I69b9942765d7fb534e549872ce86abbe2f45a577
Reviewed-on: https://chromium-review.googlesource.com/1108478
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570552}
[modify] https://crrev.com/b692f1d7ac9532e7176d521b89927ed128007331/components/offline_pages/core/offline_page_archiver.cc
[modify] https://crrev.com/b692f1d7ac9532e7176d521b89927ed128007331/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b692f1d7ac9532e7176d521b89927ed128007331/tools/metrics/histograms/histograms.xml

Comment 2 by carlosk@chromium.org, Aug 2

Components: UI>Browser>Offline
Labels: Hotlist-Fixit

Comment 3 by petewil@chromium.org, Aug 20

Status: Assigned (was: Untriaged)

Comment 4 by petewil@chromium.org, Aug 24 

This might be a good fixit candidate.  It does require some preliminary investigation.
►

Sign in to add a comment